Re: groff 1.25.0.rc1 testing

--mck3ul3txmtsubol
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Testing this rc on macOS with nixpkgs I noticed the following changes:

* The build fails with:

  /nix/store/5vmd3cqj6skjajg0yj9jl8dsddwp0700-bash-5.3p9/bin/bash: \
    line 35: ./soelim: No such file or directory

  This is likely due to soelim being called without an explicit
  absolute or relative path, which fails for isolated build
  environments like nixpkgs.

  Simply prefixing soelim with `$(builddir)/` seems to fix the issue;
  see attached prefix-soelim-with-builddir-during-build.patch.


* Furthermore the build fails with:

        GEN      doc/line-layout.eps
    make: *** [Makefile:20231: doc/line-layout.eps] Error 127

  It seems that new build dependencies on Ghostscript and ImageMagick
  have been introduced for the $(DOC_LINE_LAYOUT_EPS): "target" in
  doc/doc.am by use of the gs and convert commands.

  Aside on convert: Depending on the version groff wants to require
  newer versions of ImageMagick prefer use of the "new" `magick` command
  over the "old" `convert` command.

  While introducing new build time dependencies isn't an issue per se,
  and Ghostscript has been a soft requirement for building groff for
  quite some time, it seems it is now needed in build targets where
  previously it was not.
  Hence I'd like to suggest that these additions/changes are
  communicated appropriately in the build documentation and release
  notes—apologies if they already are and I just missed the memo.

Apart from the above minor issues the build for groff 1.25.0.rc1
on nixpkgs (and therefore likely NixOS) succeeds, yay!

I'll continue testing the behaviour of groff 1.25.0.rc1 and report back
in case of any oddities or regressions.


Best
Alexis

--mck3ul3txmtsubol
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="prefix-soelim-with-builddir-during-build.patch"

diff --git i/Makefile.am w/Makefile.am
index 4ceaae1b1..66a97197e 100644
--- i/Makefile.am
+++ w/Makefile.am
@@ -865,7 +865,7 @@ SUFFIXES += .man
 	     -e "s|[@]TMAC_MDIR[@]|`echo $(tmacdir) | sed -f $(makevarescape)`/mm|g" \
 	     -e "s|[@]TMAC_S_PREFIX[@]|\\\\%$(tmac_s_prefix)|g" \
 	     -e "s|[@]VERSION[@]|$(VERSION)|g" \
-	     $< | soelim -I $(srcdir) -I $(builddir) \
+	     $< | $(builddir)/soelim -I $(srcdir) -I $(builddir) \
 	     >$@
 
 # Version files - see script "build-aux/git-version-gen".

--mck3ul3txmtsubol--