Re: [AM] Code reviews preventative?

Scott E. Preece wrote:
> | From: "J. B. Rainsberger" <[email protected]>
> | 
> | Scott E. Preece wrote:
> | > Presumably pair programming similarly doesn't keep defects from being
> | > written, it just identifies them faster (the person typing is still
> | > going to type the error before the person reading can see what was
> | > typed). [I recognize that in some cases the pair will recognize the
> | > defect in discussion before typing, but that kind of incidental save is
> | > no more preventative than a single programmer re-reading her code before
> | > submitting it for testing - some defects simply don't live long enough
> | > to reach the metrics.]
> | 
> | Agreed: it's just a question of where we find the defect. I placed the 
> | dividing line at "did we integrate yet?" which is releasing to the rest 
> | of the team. You placed the dividing line at "did we release to the 
> | customer yet?" I think there's a considerable difference between the two.
> ---
> 
> I'm missing what you're trying to say here - inspections would normally
> be done before integration (that is, before the code branch switches
> from private to public).

"Code branch"?! I don't want to get into a discussion of code branches.

It appears that you're saying we inspect code before we integrate it. 
That's already several times per day on my projects. If we're inspecting 
code that often, we might as well do it continuously: the 
context-switching costs of running three-to-five code separate 
inspections per programmer per day are quite high.
-- 
J. B. Rainsberger,
Diaspar Software Services
http://www.diasparsoftware.com :: +1 416 791-8603
Let's write software that people understand

For more information about AM, visit the Agile Modeling Home Page at www.agilemodeling.com
--^----------------------------------------------------------------
This email was sent to: [email protected]

EASY UNSUBSCRIBE click here: http://topica.com/u/?bUrKDA.bWnbtk.Z2NtYS1h
Or send an email to: [email protected]

TOPICA - Start your own email discussion group. FREE!
http://www.topica.com/partner/tag02/create/index2.html
--^----------------------------------------------------------------