RE: [AM] Code reviews preventative?

Yes, team code reviews are useful for many things, including
- the promotion (or possible refinement) of standards,
- the identification of code smells (especially duplication that no one person is aware of), 
- awareness of code some people might have not worked with yet, and 
- the identification of objects or patterns that are reusable or relevant to upcoming stories.

In the context of a culture/metholodgy that promotes collective ownership, there is no reason for public humiliation.  Simply review the code.  We want intensional code, so the code should be able to speak for itself.  The author of the code is the team, not the person/pair who wrote a fragment of it first or modified it last.  Doing this will help reenforce collective ownership.

Steven Gordon
http://sf.asu.edu/

-----Original Message-----
From:	Stephen Cohen [mailto:[email protected]]
Sent:	Tue 2/3/2004 8:42 PM
To:	[email protected]
Cc:	
Subject:	RE: [AM] Code reviews preventative?

The benefits of code reviews can go beyond simply finding bugs in the
product.  It is a chance to extend the boundaries of collective
ownership.  Reviews provide an opportunity for the team to identify and
promote good work from a project up to an enterprise repository.  Like
wise, it allows the project teams to cross-pollinate lessons learned and
techniques.

Of course there is the potential of public humiliation but that too can
net broadly positive results if handled gently "-)

-- Stephen

For more information about AM, visit the Agile Modeling Home Page at www.agilemodeling.com
--^----------------------------------------------------------------
This email was sent to: [email protected]

EASY UNSUBSCRIBE click here: http://topica.com/u/?bUrKDA.bWnbtk.Z2NtYS1h
Or send an email to: [email protected]

TOPICA - Start your own email discussion group. FREE!
http://www.topica.com/partner/tag02/create/index2.html
--^----------------------------------------------------------------