Re: Ambiguous Refactoring Solution
"bryanedds" <[email protected]>
| Newsgroups | gmane.comp.programming.refactoring |
|---|---|
| Message-ID | <[email protected]> |
> If, on the other hand, you have no reason to be looking at this class
> in the first place. i.e. it isn't related to any story that you are
> working on, then I agree with the other posters who suggest that you
> should wait until there is a reason. It's not clear to me that that is
> the case here. If you have a reason to be looking at the class, and it
> sucks, you should fix it.
The only reason I'm looking at the class is its violation of SRP. It contains no duplication, causes no duplication, its average method size is 2 - 3 lines, it's pretty clear what it does even if it does two things.
The problem is that there are many ways to address a violation of SRP. The realization of an SRP violation does not seem to provide enough context to disambiguate a refactor from its applicable subset.
------------------------------------
Yahoo! Groups Links
<*> To visit your group on the web, go to:
http://groups.yahoo.com/group/refactoring/
<*> Your email settings:
Individual Email | Traditional
<*> To change settings online go to:
http://groups.yahoo.com/group/refactoring/join
(Yahoo! ID required)
<*> To change settings via email:
mailto:[email protected]
mailto:[email protected]
<*> To unsubscribe from this group, send an email to:
[email protected]
<*> Your use of Yahoo! Groups is subject to:
http://docs.yahoo.com/info/terms/