Re: Ambiguous Refactoring Solution

On Tue, Sep 22, 2009 at 4:20 PM, Richard <[email protected]> wrote:
>
>
>
> In article <[email protected]>,
>
> Adam Sroka <[email protected]> writes:
>
> > I honestly can't imagine a 613 line class file that doesn't have some
> > obvious smells - even in C++ ;-) [...]
>
> I really don't like blanket statements like that. A 613 line method
> is one thing, I don't view a 613 line class as necessarily a smell.
>

I said, "I can't imagine... Though, I suppose anything could happen."
I don't think you are in a position to dictate what I can imagine ;-)

I also didn't say that a 613 line class was a smell. I'm just betting
that a class that size has a few smells (BTW, OP admitted that the
class in question does.) In over twenty years of hacking code I can't
recall a class that large that I couldn't make smaller and wasn't
better for it.

> Plus we're counting lines, not statements. Depending on your
> formatting style, a few statements can easily take up twice as many
> lines.
>

Which is a mistake to begin with. You are right, we should be counting
members or something more representative. Still, a single file with
613 lines wouldn't fit on a few pages in my editor. I would end up
breaking it down for that reason alone. YMMV.


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/refactoring/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/refactoring/join
    (Yahoo! ID required)

<*> To change settings via email:
    mailto:[email protected] 
    mailto:[email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/