Maybe they should not be managers of software teams in the first place?
Kevin
Sent from my iPhone
> On 1 Oct 2015, at 22:10, Cass Dalton [email protected] [SCRUMDEVELOPMENT] <[email protected]> wrote:
>
> I can tell you what I think most managers think you get out of code reviews that you don't: defect reduction. Finding defects through code inspection is very difficult and inefficient.
> In my opinion, the single biggest benefit a team gets out of code reviews is knowledge transfer. It's the same type of knowledge transfer you get from pair programming (although not as intense), but it is distributed among all reviewers, not just within a pair. This knowledge transfer has multiple side effects:
> - More people understand more of the code base. Management should care about this because it reduces institutional knowledge and knowledge silos
> - The developers learn from each other. Management should care about this because, as managers of knowledge workers, knowledge and experience are the true commodities they are building.
> - The conversations also spur design discussions and therefore the team produces a better product. Management obviously cares about this.
>
> One of the concerns I have heard about code reviews is the amount of time devoted to process vs actual development. My response to that is that productivity of knowledge workers can't be measured like assembly line workers. The time developers spend talking about the design or whiteboarding is just as valuable as the time they spend banging on the keyboard. In fact, often an hour of whiteboarding can save 10 hours of banging on the keyboard.
>
>> On Thu, Oct 1, 2015 at 4:51 PM, Adam Sroka [email protected] [SCRUMDEVELOPMENT] <[email protected]> wrote:
>>
>> This probably isn't what you were looking for, but...
>>
>> I wish more managers understood that code reviews are a remedial stop-gap for the lack of more radical collaboration like the kind we see with pair programming and mob programming. The feedback is coming too late, generally after a complete implementation has already been offered. If we don't act on it it is waste, and if we do it is failure demand.
>>
>>> On Thu, Oct 1, 2015 at 8:42 AM, [email protected] [SCRUMDEVELOPMENT] <[email protected]> wrote:
>>>
>>> A vendor has asked me to write a white paper about the barriers that developers encounter in doing code reviews – particularly in regard to getting their managers to care about doing them, or how to sell the boss on adding it to the development process. (Although it’s sponsored, this is written for techies, not a commercial for the vendor… whom I won’t even mention here.)
>>>
>>>
>>>
>>> That is: I plan to write a genuinely-useful document that you want to read all the way through. It might be titled, "7 ways to sell the boss on doing code reviews," or something akin to that.
>>>
>>>
>>>
>>> So here’s my two questions:
>>>
>>>
>>>
>>> · What one thing, ONE THING, do you wish the boss (or powers that be) understood about code review?
>>>
>>> · Why did you choose THAT as the one thing to wish for?
>>>
>>>
>>>
>>> Nobody is being quoted here. The closest I might get is to refer to someone indirectly to give the information credibility, something like, “Kim, a programmer at a Midwest insurance company, told me about about the time when….” So you can speak openly (and privately if you’re more comfortable). Though I suspect that this might spark a conversation that’d benefit everybody, so don’t be shy.
>>>
>>>
>>>
>>> It’d help me if you included a LITTLE bit of background for yourself, so I could include that “programmer at an insurance company” attribution, should it back up the text.
>>>
>>>
>>>
>>> Also let me know about your experience with code review. Is it something you use now, but want to improve? Something you’d like to include in your dev process? What difference would it make to get more support from Management for doing code reviews?
>>>
>>>
>>>
>>> Incidentally, if you hate code reviews or just aren’t interested… thanks, but that doesn’t help me write this piece, which does start with the premise that code reviews are valuable. So it’s groovy with me if you don’t find them useful, but I’ll be ignoring that input for the purposes of this white paper.
>>>
>>>
>>>
>>> --Esther
>>>
>>>
>>> twitter.com/estherschindler
>>>
>>>
>
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.