Re: [testdrivendevelopment] "bottom-up" TDD and common behaviors
"Charlie Poole" <[email protected]> Thu, 5 Dec 2019 07:45:27 -0800
| Newsgroups | gmane.comp.programming.test-driven-development |
|---|---|
| Message-ID | <CAJ+=fjgmSEaP9xh4290hMPE3EyvkQb25ZXAMk3Js2UVMXdm7Tg@mail.gmail.com> |
--00000000000031d5390598f6d22f Content-Type: text/plain; charset="UTF-8" I see it as well. I've noticed other threads being split as well. On Thu, Dec 5, 2019, 6:42 AM Giorgio Vespucci <[email protected]> wrote: > I don't know why, but it seems this thread is completely separated, at > least in my Gmail inbox, from the original Brian's one. > Am I the only one seeing this? :| > > On Wed, 4 Dec 2019 at 07:44, Avi Kessner <[email protected]> wrote: > >> So this is definitely required behavior and it will be your own, so it >> needs to be tested. >> On the other hand, it's a very specific implementation detail which could >> change when the technology changes and we don't want that to impact actual >> behavior related tests about animals. >> >> What I would do is make a transformation decorator and then test sample >> data to see that it gets transformed correctly. If Ecto ever changes, that >> transformation decorator can do nothing if needed. >> You basically need a map of fields that can be changed and the >> transformation needed for that field. >> >> A bit more work, but it allows for a change in Ecto or a change in >> understanding of Ecto to not impact the main test suite. >> >> On Wed, Dec 4, 2019, 01:50 Brian Marick <[email protected]> wrote: >> >>> Yes. >>> >>> On Dec 3, 2019, at 5:31 AM, Avi Kessner <[email protected]> wrote: >>> >>> If I understand correctly, the code here is specifically for doing an >>> Ecto transformation, correct? If you decide not to use Ecto the need for >>> this abstraction is removed? >>> >>> >>> > > -- > > > Giorgio Vespucci > [image: https://]about.me/giorgiovespucci > <https://about.me/giorgiovespucci?promo=email_sig> > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#35808): https://groups.io/g/testdrivendevelopment/message/35808 Mute This Topic: https://groups.io/mt/64491946/3268755 Group Owner: [email protected] Unsubscribe: https://groups.io/g/testdrivendevelopment/leave/6156322/744556386/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=- --00000000000031d5390598f6d22f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">I see it as well. I've noticed other threads being sp= lit as well.</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"= gmail_attr">On Thu, Dec 5, 2019, 6:42 AM Giorgio Vespucci <<a href=3D"ma= ilto:[email protected]">[email protected]</a>> wrote:<= br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;borde= r-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">I don't know w= hy, but it seems this thread=C2=A0is completely separated, at least in my G= mail inbox, from the original Brian's one.<div>Am I the only one seeing= = =C2=A0this? :|</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, 4 Dec 2019 at 07:44, Avi Kessner <<a href= =3D"mailto:[email protected]" target=3D"_blank" rel=3D"noreferrer">akessn= [email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quote" styl= e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin= g-left:1ex"><div dir=3D"auto">So this is definitely required behavior and i= t will be your own, so it needs to be tested.<div dir=3D"auto">On the other= hand, it's a very specific implementation detail which could change wh= en the technology changes and we don't want that to impact actual behav= ior related tests about animals.</div><div dir=3D"auto"><br></div><div dir= =3D"auto">What I would do is make a transformation decorator and then test= sample data to see that it gets transformed correctly.=C2=A0 If Ecto ever = changes, that transformation decorator can do nothing if needed.</div><div = dir=3D"auto">You basically need a map of fields that can be changed and the= transformation needed for that field.</div><div dir=3D"auto"><br></div><di= v dir=3D"auto">A bit more work, but it allows for a change in Ecto or a cha= nge in understanding of Ecto to not impact the main test suite.</div></div>= <br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed= , Dec 4, 2019, 01:50 Brian Marick <<a href=3D"mailto:[email protected]= " target=3D"_blank" rel=3D"noreferrer">[email protected]</a>> wrote:<b= r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex= ;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>Yes.<br= ><div><br><blockquote type=3D"cite"><div>On Dec 3, 2019, at 5:31 AM, Avi Ke= ssner <<a href=3D"mailto:[email protected]" rel=3D"noreferrer noreferre= r" target=3D"_blank">[email protected]</a>> wrote:</div><br><div><span = style=3D"font-family:Helvetica;font-size:16px;font-style:normal;font-varian= t-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;tex= t-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-d= ecoration:none;float:none;display:inline">If I understand correctly, the co= de here is specifically=C2=A0for doing an Ecto transformation, correct? If = you decide not to use Ecto the need for this abstraction is removed?</span>= <br style=3D"font-family:Helvetica;font-size:16px;font-style:normal;font-va= riant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start= ;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;te= xt-decoration:none"></div></blockquote></div><br></div></div> </blockquote></div> <p></p><p></p></blockquote></div><br clear=3D"all"><div><br></div>-- <br><= div dir=3D"ltr"><div dir=3D"ltr"><table border=3D"0" cellpadding=3D"0" cell= spacing=3D"0" style=3D"margin:0px;padding:0px;border:0px;outline:0px;font-s= ize:14px;font-family:proxima-nova-1,proxima-nova-2,Tahoma,Helvetica,Verdana= ,sans-serif,"Segoe UI Emoji","Segoe UI Symbol",Symbola,= EmojiSymbols;vertical-align:baseline;border-spacing:0px;color:rgb(51,51,51)= ;line-height:18.2px"><tbody style=3D"margin:0px;padding:0px;border:0px;outl= ine:0px;font-weight:inherit;font-style:inherit;font-family:inherit;vertical= -align:baseline"><tr style=3D"margin:0px;padding:0px;border:0px;outline:0px= ;font-weight:inherit;font-style:inherit;font-family:inherit;vertical-align:= baseline"><td style=3D"padding:0px;border:0px;outline:0px;font-style:inheri= t;font-size:0px;font-family:inherit;vertical-align:baseline;width:auto;heig= ht:30px">=C2=A0</td></tr><tr style=3D"margin:0px;padding:0px;border:0px;out= line:0px;font-weight:inherit;font-style:inherit;font-family:inherit;vertica= l-align:baseline"><td style=3D"padding:0px;border:0px;outline:0px;font-styl= e:inherit;font-family:inherit;vertical-align:baseline;width:auto"><div styl= e=3D"margin:0px;padding:0px;border:0px;outline:0px;font-weight:inherit;font= -style:inherit;font-family:inherit;vertical-align:baseline;line-height:0"><= a href=3D"https://about.me/giorgiovespucci?promo=3Demail_sig" style=3D"marg= in:0px;padding:0px;border:0px;outline:0px;font-weight:inherit;font-style:in= herit;font-family:inherit;vertical-align:baseline;color:rgb(43,130,173);tex= t-decoration:none;display:inline-block" target=3D"_blank" rel=3D"noreferrer= "><table border=3D"0" cellpadding=3D"0" cellspacing=3D"0" style=3D"margin:0= px;padding:0px;border:0px;outline:0px;font-weight:inherit;font-style:inheri= t;font-family:inherit;vertical-align:baseline;border-spacing:0px"><tbody st= yle=3D"margin:0px;padding:0px;border:0px;outline:0px;font-weight:inherit;fo= nt-style:inherit;font-family:inherit;vertical-align:baseline"><tr style=3D"= margin:0px;padding:0px;border:0px;outline:0px;font-weight:inherit;font-styl= e:inherit;font-family:inherit;vertical-align:baseline"><td align=3D"left" v= align=3D"top" style=3D"padding:0px;border:0px;outline:0px;font-style:inheri= t;font-family:inherit;vertical-align:top;width:auto;line-height:1"><div sty= le=3D"margin:0px;padding:0px;border:0px;outline:0px;font-weight:bold;font-s= tyle:inherit;font-size:18px;font-family:proxima-nova-1,Proxima-Nova,Helveti= ca,Arial,sans-serif;vertical-align:baseline;line-height:1;color:rgb(51,51,5= 1)">Giorgio Vespucci</div></td></tr><tr style=3D"margin:0px;padding:0px;bor= der:0px;outline:0px;font-weight:inherit;font-style:inherit;font-family:inhe= rit;vertical-align:baseline"><td align=3D"left" valign=3D"top" style=3D"pad= ding:0px;border:0px;outline:0px;font-style:inherit;font-family:inherit;vert= ical-align:top;width:auto;line-height:1"><div style=3D"margin:3px 0px 0px;p= adding:0px;border:0px;outline:0px;font-weight:inherit;font-style:inherit;fo= nt-size:12px;font-family:proxima-nova-1,Proxima-Nova,Helvetica,Arial,sans-s= erif;vertical-align:baseline"><img alt=3D"https://" width=3D"0" height=3D"0= " style=3D"margin:0px;padding:0px;border:0px;outline:0px;font-weight:inheri= t;font-style:inherit;font-family:inherit;vertical-align:baseline;display:bl= ock;width:0px;height:0px;overflow:hidden">about.me/giorgiovespucci</div></t= d></tr></tbody></table></a>=C2=A0 =09 =09</div></td></tr><tr style=3D"margi= n:0px;padding:0px;border:0px;outline:0px;font-weight:inherit;font-style:inh= erit;font-family:inherit;vertical-align:baseline"><td style=3D"padding:0px;= border:0px;outline:0px;font-style:inherit;font-size:0px;font-family:inherit= ;vertical-align:baseline;width:auto;height:20px"><img src=3D"https://about.= me/t/sig?u=3Dgiorgiovespucci" width=3D"1" height=3D"1" style=3D"margin:0px;= padding:0px;border:0px;outline:0px;font-weight:inherit;font-style:inherit;f= ont-family:inherit;vertical-align:baseline;overflow:hidden"></td></tr></tbo= dy></table></div></div> </p></p></blockquote></div> <div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div> <hr> Groups.io Links:<p> You receive all messages sent to this group. <p> <a target=3D"_blank" href=3D"https://groups.io/g/testdrivendevelopment/mes= sage/35808">View/Reply Online (#35808)</a> | <a target=3D"_blank" href=3D"mailto:[email protected]?subj= ect=3DRe:%20Re%3A%20%5Btestdrivendevelopment%5D%20%22bottom-up%22%20TDD%20a= nd%20common%20behaviors">Reply To Group</a> | <a target=3D"_blank" href=3D"mailto:[email protected]?subject= =3DPrivate:%20Re:%20Re%3A%20%5Btestdrivendevelopment%5D%20%22bottom-up%22%= 20TDD%20and%20common%20behaviors">Reply To Sender</a> | <a target=3D"_blank" href=3D"https://groups.io/mt/64491946/3268755">Mu= te This Topic</a> | <a href=3D"https://groups.io/g/testdrivendevelopment/post">New Topic</a>= <br> <br> <a href=3D"https://groups.io/g/testdrivendevelopment/editsub/3268755">Your= Subscription</a> | <a href=3D"mailto:[email protected]">Contact Group Own= er</a> | <a href=3D"https://groups.io/g/testdrivendevelopment/leave/6156322/7445563= 86/xyzzy">Unsubscribe</a> [[email protected]]<br> <div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div> --00000000000031d5390598f6d22f--