Re: I have a pull request Parts I think we might want to sync with SCons

Jason,

Interesting.
Seems like the patch could be avoided if the string provided

-shlibLinkAction = SCons.Action.Action('${TEMPFILE("$SHLINK
$SHLINKFLAGS $_SHLINK_TARGETS $_LIBDIRFLAGS $_LIBFLAGS $_PDB
$_SHLINK_SOURCES")}')

was something like:

-shlibLinkAction = SCons.Action.Action('$SHLINKACTION')


That would allow the user to do this independent of the tool's code?

_Bill


On Fri, Feb 24, 2017 at 8:41 AM, Jason Kenny <[email protected]> wrote:

>
> Hi guy,
>
> I have a pull request for mslink.py tool in Parts that I think is an issue
> we would want as a general solution for linking on the tools that deal with
> linking in SCons
>
> The request is here:
> https://bitbucket.org/sconsparts/parts/pull-requests/17/introduced-sh-
> linktrailflags-to-mslinkpy/diff
>
> I would like to your guys option on the matter. Given you think you like
> the idea in general, do you like the value being used? If we would like to
> sync this change, I think we would want to keep a common value between
> Parts and SCons to help the users.
>
> Thanks
> Jason
>
> _______________________________________________
> Scons-dev mailing list
> [email protected]
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>

_______________________________________________
Scons-dev mailing list
[email protected]
https://pairlist2.pair.net/mailman/listinfo/scons-dev