Re: tools and testing

Bill/Russel,

I explicitly resolved Issue 1924 with PR 304.

http://scons.tigris.org/issues/show_bug.cgi?id=1924
https://bitbucket.org/scons/scons/pull-requests/304/issue-1924-updated-d-scanner-per-d/diff

Issue 1924 and 2993 are explicitly related in code area. I know this
because the Issues references a PR that my fix replaced.
http://scons.tigris.org/issues/show_bug.cgi?id=2993

Since I resolved Issue 1924 at the D language definition level, it is
likely that Issue 2993 is resolved and I just didn't realized I fixed
more than 1 issue simultaneously. I think the 3rd example from the
CHANGES.txt is exactly what Issue 1924 is asking for...

https://bitbucket.org/scons/scons/src/b8e7614a7a9240fb15e87b0a9e7f04a9056240df/src/CHANGES.txt?at=default&fileviewer=file-view-default
- Updated D language scanner support to latest: 2.071.1. (PR #1924)
  https://dlang.org/spec/module.html accessed 11 August 2016
  - Enhancements:
    - Added support for selective imports: "import A : B, C;" -> A
    - Added support for renamed imports. "import B = A;" -> A
    - Supports valid combinations: "import A, B, CCC = C, DDD = D :
EEE = FFF;" -> A, B, C, D

If I accidentally resolved that issue too, just add it to the CHANGES.txt.

V/R,
William

On Fri, Apr 21, 2017 at 2:55 PM, William Blevins <[email protected]> wrote:
> It might be. I submitted a fix for 1924 as PR 304. That should have been
> merged...
>
> On Apr 21, 2017 2:17 PM, "Bill Deegan" <bill-cJFiu+DHMVC5azolltMz9laTQe2KTcn/@public.gmane.org> wrote:
>
> :)
> Sounds good.
>
> On Fri, Apr 21, 2017 at 10:17 AM, Russel Winder <[email protected]>
> wrote:
>>
>> On Fri, 2017-04-21 at 09:36 -0700, Bill Deegan wrote:
>> > Is this bug resolved?
>> >
>> > http://scons.tigris.org/issues/show_bug.cgi?id=2993
>> >
>> >
>>
>> I suspect not given the name of the reporter. :-)
>>
>> I'd have to spend a bit of time properly researching the report,
>> creating a test, and then putting a solution in place. I can give that
>> a go in a couple of weeks. It is though nothing to do with the current
>> pull request, it has to be a separate piece of work.
>>
>> --
>> Russel.
>>
>> =============================================================================
>> Dr Russel Winder      t: +44 20 7585 2200   voip:
>> sip:[email protected]
>> 41 Buckmaster Road    m: +44 7770 465 077   xmpp: [email protected]
>> London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder
>>
>> _______________________________________________
>> Scons-dev mailing list
>> [email protected]
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>
>
> _______________________________________________
> Scons-dev mailing list
> [email protected]
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>