Re: tools and testing

Russel Winder <[email protected]> Tue, 06 Jun 2017 16:43:30 +0100
Newsgroups	gmane.comp.programming.tools.scons.devel
Message-ID	<[email protected]>
On Fri, 2017-04-21 at 18:55 -0400, William Blevins wrote:
> Bill/Russel,
> 
> I explicitly resolved Issue 1924 with PR 304.

There doesn't seem to be a test in test/D/Issues/1924 to check for no
regressions, did the test go elsewhere?

> http://scons.tigris.org/issues/show_bug.cgi?id=1924
> https://bitbucket.org/scons/scons/pull-requests/304/issue-1924-update
> d-d-scanner-per-d/diff
> 
> Issue 1924 and 2993 are explicitly related in code area. I know this
> because the Issues references a PR that my fix replaced.
> http://scons.tigris.org/issues/show_bug.cgi?id=2993

Again no test in test/D/Issues/2993 unless the test was names something
else.

I'll see if I can suss this one out.


> Since I resolved Issue 1924 at the D language definition level, it is
> likely that Issue 2993 is resolved and I just didn't realized I fixed
> more than 1 issue simultaneously. I think the 3rd example from the
> CHANGES.txt is exactly what Issue 1924 is asking for...
> 
> https://bitbucket.org/scons/scons/src/b8e7614a7a9240fb15e87b0a9e7f04a
> 9056240df/src/CHANGES.txt?at=default&fileviewer=file-view-default
> - Updated D language scanner support to latest: 2.071.1. (PR #1924)
>   https://dlang.org/spec/module.html accessed 11 August 2016
>   - Enhancements:
>     - Added support for selective imports: "import A : B, C;" -> A
>     - Added support for renamed imports. "import B = A;" -> A
>     - Supports valid combinations: "import A, B, CCC = C, DDD = D :
> EEE = FFF;" -> A, B, C, D
> 
> If I accidentally resolved that issue too, just add it to the
> CHANGES.txt.
> 
> V/R,
> William
> 

-- 
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:[email protected]
41 Buckmaster Road    m: +44 7770 465 077   xmpp: [email protected]
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder

_______________________________________________
Scons-dev mailing list
[email protected]
https://pairlist2.pair.net/mailman/listinfo/scons-dev
signature.asc (application/pgp-signature, 833 B)