Re: PR 3155
Bill Deegan <bill-cJFiu+DHMVC5azolltMz9laTQe2KTcn/@public.gmane.org>
| Newsgroups | gmane.comp.programming.tools.scons.devel |
|---|---|
| Message-ID | <CAEyG4CEhDtSTs-BXKdr=UzZvHXv638iWnJvjLD-tpWzy6Q7=Vw@mail.gmail.com> |
I put some feedback on the PR almost as soon as you submitted it that you have yet to respond to. We need a test which fails under normal scons before your changes and passes after, as we do with pretty much any and all pull requests. -Bill On Mon, Jul 23, 2018 at 5:42 PM, Jason Kenny <[email protected]> wrote: > Hi Bill, > > > > Wanted to know what are your concerns about PR 3155. It current addresses > and fixes a number of small issues ( mostly on windows) the pass rate is > better. > > > > Any reason for not merging this? > > > > Jason > > _______________________________________________ > Scons-dev mailing list > [email protected] > https://pairlist2.pair.net/mailman/listinfo/scons-dev > > _______________________________________________ Scons-dev mailing list [email protected] https://pairlist2.pair.net/mailman/listinfo/scons-dev