Re: MSVC exception

Mats Wichmann <[email protected]> Mon, 4 Feb 2019 11:32:07 -0700
Newsgroups gmane.comp.programming.tools.scons.devel
Message-ID <[email protected]>
On 2/4/19 11:16 AM, Daniel Moody wrote:
> I tested master on a windows system that didn't have any MSVC tools
> installed and I got:
> 
>   File
> "C:\Users\dmmoody\Workspace\scons\src\engine\SCons\Tool\MSCommon\vc.py",
> line 307, in find_vc_pdir_vswhere
>     vc_pdir = os.path.join(vsdir[0], 'VC')
> IndexError: list index out of range
> 
> when creating an environment. It seems the Popen call returns an empty
> string from stdout and that gets converted to an empty list. Seems we
> should do some list size checking here? Anyone else can verify?

sure, should check after communicate() that there's actually anything
to process.