fix for partial reads from cache

--0000000000000ca79805b2ac80c4
Content-Type: multipart/alternative; boundary="0000000000000ca79605b2ac80c2"

--0000000000000ca79605b2ac80c2
Content-Type: text/plain; charset="UTF-8"

Hi scons devs,

Here's a fix to clean up reads from the cache that fail part way through.
Absolutely experienced by us in production (non-local shared cache).  This
may be what my last UUID temp name fix was really trying to address, but I
can imagine edge cases that the UUID fix could still improve.

This could also have been fixed in Taskmaster.py near my comment change,
but the reasons for cleanup seemed different enough to keep them distinct.

Also cleaned up the logged message tense, as message is logged before the
cache retrieval begins.

Thanks!
--
*Raven Kopelman* | Team Lead, Senior Developer

Safe Software Inc.
*T* 604.501.9985 x 331 | *F* 604.501.9965
[email protected] | www.safe.com

<http://www.safe.com/emailsignature>

--0000000000000ca79605b2ac80c2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi scons devs,</div><div><br></div><div>Here&#39;s a =
fix to clean up reads from the cache that fail part way through.=C2=A0 Abso=
lutely experienced by us in production (non-local shared cache).=C2=A0 This=
 may be what my last UUID temp name fix was really trying to address, but I=
 can imagine edge cases that the UUID fix could still improve.</div><div><b=
r></div><div>This could also have been fixed in Taskmaster.py near my comme=
nt change, but the reasons for cleanup seemed different enough to keep them=
 distinct.<br></div><div><br></div><div>Also cleaned up the logged message =
tense, as message is logged before the cache retrieval begins.</div><div><b=
r></div><div>Thanks!<br></div><div><div><div dir=3D"ltr" class=3D"gmail_sig=
nature" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=
=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr">=
<div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div=
 dir=3D"ltr">--<br><b>Raven Kopelman</b> | Team Lead, Senior Developer<br><=
br><div dir=3D"ltr">Safe Software Inc.</div><b>T</b> 604.501.9985 x 331 | <=
b>F</b> 604.501.9965</div><div dir=3D"ltr"><a href=3D"mailto:raven.kopelman=
@safe.com" target=3D"_blank">[email protected]</a> | <a href=3D"http:=
//www.safe.com" target=3D"_blank">www.safe.com</a></div><div dir=3D"ltr"><d=
iv><br></div><div><div><a href=3D"http://www.safe.com/emailsignature" targe=
t=3D"_blank"><img src=3D"http://cdn.safe.com/emailsignature.jpg"></a><br></=
div></div></div></div></div></div></div></div></div></div></div></div></div=
></div></div></div></div></div></div></div></div></div></div>

--0000000000000ca79605b2ac80c2--

--0000000000000ca79805b2ac80c4
Content-Type: text/x-patch; charset="US-ASCII"; name="partialReadFix.patch"
Content-Disposition: attachment; filename="partialReadFix.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kgse74bc0>
X-Attachment-Id: f_kgse74bc0

ZGlmZiAtcnUgLXggJyoucHljJyBTQ29ucy5vcmlnL0NhY2hlRGlyLnB5IC91c3IvbG9jYWwvbGli
L3B5dGhvbjIuNy9kaXN0LXBhY2thZ2VzL3Njb25zL1NDb25zL0NhY2hlRGlyLnB5Ci0tLSBTQ29u
cy5vcmlnL0NhY2hlRGlyLnB5CTIwMjAtMTAtMjMgMTY6MTI6NDQuNzczMzQ5Mjg1IC0wNzAwCisr
KyAvdXNyL2xvY2FsL2xpYi9weXRob24yLjcvZGlzdC1wYWNrYWdlcy9zY29ucy9TQ29ucy9DYWNo
ZURpci5weQkyMDIwLTEwLTIzIDE2OjE5OjQ4LjY3NjU3MDM4MiAtMDcwMApAQCAtNTYsNyArNTYs
MjAgQEAKICAgICAgICAgaWYgZnMuaXNsaW5rKGNhY2hlZmlsZSk6CiAgICAgICAgICAgICBmcy5z
eW1saW5rKGZzLnJlYWRsaW5rKGNhY2hlZmlsZSksIHQuZ2V0X2ludGVybmFsX3BhdGgoKSkKICAg
ICAgICAgZWxzZToKLSAgICAgICAgICAgIGVudi5jb3B5X2Zyb21fY2FjaGUoY2FjaGVmaWxlLCB0
LmdldF9pbnRlcm5hbF9wYXRoKCkpCisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAg
ZW52LmNvcHlfZnJvbV9jYWNoZShjYWNoZWZpbGUsIHQuZ2V0X2ludGVybmFsX3BhdGgoKSkKKyAg
ICAgICAgICAgIGV4Y2VwdDoKKyAgICAgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAg
ICAgICMgSW4gY2FzZSBmaWxlIHdhcyBwYXJ0aWFsbHkgcmV0cmlldmVkIChhbmQgbm93IGNvcnJ1
cHQpCisgICAgICAgICAgICAgICAgICAgICMgZGVsZXRlIGl0IHRvIGF2b2lkIHBvaXNvbmluZyBj
b21tYW5kcyBsaWtlICdhcicgdGhhdAorICAgICAgICAgICAgICAgICAgICAjIHJlYWQgZnJvbSB0
aGUgaW5pdGlhbCBzdGF0ZSBvZiB0aGUgZmlsZSB0aGV5IGFyZSB3cml0aW5nCisgICAgICAgICAg
ICAgICAgICAgICMgdG8uCisgICAgICAgICAgICAgICAgICAgIHQuZnMudW5saW5rKHQuZ2V0X2lu
dGVybmFsX3BhdGgoKSkKKyAgICAgICAgICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICAgICAg
ICAgIHBhc3MKKworICAgICAgICAgICAgICAgIHJhaXNlCisKICAgICAgICAgICAgIHRyeToKICAg
ICAgICAgICAgICAgICBvcy51dGltZShjYWNoZWZpbGUsIE5vbmUpCiAgICAgICAgICAgICBleGNl
cHQgT1NFcnJvcjoKQEAgLTcxLDcgKzg0LDcgQEAKICAgICBjZCA9IGVudi5nZXRfQ2FjaGVEaXIo
KQogICAgIGNhY2hlZGlyLCBjYWNoZWZpbGUgPSBjZC5jYWNoZXBhdGgodCkKICAgICBpZiB0LmZz
LmV4aXN0cyhjYWNoZWZpbGUpOgotICAgICAgICByZXR1cm4gIlJldHJpZXZlZCBgJXMnIGZyb20g
Y2FjaGUiICUgdC5nZXRfaW50ZXJuYWxfcGF0aCgpCisgICAgICAgIHJldHVybiAiUmV0cmlldmlu
ZyBgJXMnIGZyb20gY2FjaGUiICUgdC5nZXRfaW50ZXJuYWxfcGF0aCgpCiAgICAgcmV0dXJuIE5v
bmUKIAogQ2FjaGVSZXRyaWV2ZSA9IFNDb25zLkFjdGlvbi5BY3Rpb24oQ2FjaGVSZXRyaWV2ZUZ1
bmMsIENhY2hlUmV0cmlldmVTdHJpbmcpCmRpZmYgLXJ1IC14ICcqLnB5YycgU0NvbnMub3JpZy9U
YXNrbWFzdGVyLnB5IC91c3IvbG9jYWwvbGliL3B5dGhvbjIuNy9kaXN0LXBhY2thZ2VzL3Njb25z
L1NDb25zL1Rhc2ttYXN0ZXIucHkKLS0tIFNDb25zLm9yaWcvVGFza21hc3Rlci5weQkyMDIwLTEw
LTIzIDE2OjEyOjQ0Ljc4NTM0OTM3OCAtMDcwMAorKysgL3Vzci9sb2NhbC9saWIvcHl0aG9uMi43
L2Rpc3QtcGFja2FnZXMvc2NvbnMvU0NvbnMvVGFza21hc3Rlci5weQkyMDIwLTEwLTIzIDE1OjU1
OjQxLjUyMTc1ODc2MiAtMDcwMApAQCAtMjQzLDEwICsyNDMsMTMgQEAKICAgICAgICAgICAgICAg
ICBjYWNoZWRfdGFyZ2V0cy5hcHBlbmQodCkKICAgICAgICAgICAgIGlmIGxlbihjYWNoZWRfdGFy
Z2V0cykgPCBsZW4oc2VsZi50YXJnZXRzKToKICAgICAgICAgICAgICAgICAjIFJlbW92ZSB0YXJn
ZXRzIGJlZm9yZSBidWlsZGluZy4gSXQncyBwb3NzaWJsZSB0aGF0IHdlCi0gICAgICAgICAgICAg
ICAgIyBwYXJ0aWFsbHkgcmV0cmlldmVkIHRhcmdldHMgZnJvbSB0aGUgY2FjaGUsIGxlYXZpbmcK
LSAgICAgICAgICAgICAgICAjIHRoZW0gaW4gcmVhZC1vbmx5IG1vZGUuIFRoYXQgbWlnaHQgY2F1
c2UgdGhlIGNvbW1hbmQKKyAgICAgICAgICAgICAgICAjIHJldHJpZXZlZCBhIHN1YnNldCBvZiB0
YXJnZXRzIGZyb20gdGhlIGNhY2hlLCBsZWF2aW5nCisgICAgICAgICAgICAgICAgIyB0aGVtIGlu
IGFuIGluY29uc2lzdGVudCBzdGF0ZS4gVGhhdCBtaWdodCBjYXVzZSB0aGUgY29tbWFuZAogICAg
ICAgICAgICAgICAgICMgdG8gZmFpbC4KICAgICAgICAgICAgICAgICAjCisgICAgICAgICAgICAg
ICAgIyBOb3RlIHRoYXQgcmV0cmlldmVfZnJvbV9jYWNoZSgpIGVuc3VyZXMgbm8gc2luZ2xlIHRh
cmdldCBjYW4KKyAgICAgICAgICAgICAgICAjIGJlIHBhcnRpYWxseSByZXRyaWV2ZWQgKGZpbGUg
bGVmdCBpbiBjb3JydXB0IHN0YXRlKS4KKyAgICAgICAgICAgICAgICAjCiAgICAgICAgICAgICAg
ICAgZm9yIHQgaW4gY2FjaGVkX3RhcmdldHM6CiAgICAgICAgICAgICAgICAgICAgIHRyeToKICAg
ICAgICAgICAgICAgICAgICAgICAgIHQuZnMudW5saW5rKHQuZ2V0X2ludGVybmFsX3BhdGgoKSkK
--0000000000000ca79805b2ac80c4
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Scons-dev mailing list
[email protected]
https://pairlist2.pair.net/mailman/listinfo/scons-dev

--0000000000000ca79805b2ac80c4--