Re: Patch to DorothyLocker

Thomas Klaeger <[email protected]> Thu, 23 Sep 2004 13:58:39 +0200
Newsgroups gmane.comp.pythin.pyds.devel
Message-ID <[email protected]>
I spent some time looking through the new code and as far as I can see 
the code looks good.

Georg, could you please check in the patch Garth attached to his last email?

Regards,
Thomas.

Garth T Kidd schrieb:
> All done! I renamed the exception, made it a subclass of AssertionError,
> added specific sub-exceptions, and <drumroll/> added unit tests to make sure
> everything works. If anyone has any ideas for additional unit tests (stress
> tests with a hundred threads each going for the same lock, for example),
> please let me know and/or submit code. 
> 
> Thomas, I'd much appreciate it if you could go over my code to see if you
> can spot anything. 
> 
> Yours,
> Garth. 
> 
> -----Original Message-----
> From: Garth T Kidd [mailto:garth-OnzZ1s1DREKDegMON/[email protected]] 
> Sent: Thursday, 23 September 2004 7:25 AM
> To: 'Thomas Klaeger'
> Cc: 'pyds-dev-iYtK5bfT9M//Ad8WF/[email protected]'
> Subject: RE: [Pyds-dev] Patch to DorothyLocker
> 
> Excellent idea, that. Whining and whining loudly is fine; all I had to do
> was consolidate down to only one ``print`` so output didn't interleave. New
> version attached. 
> 
> -----Original Message-----
> From: Garth T Kidd [mailto:garth-OnzZ1s1DREKDegMON/[email protected]]
> Sent: Thursday, 23 September 2004 7:18 AM
> To: 'Thomas Klaeger'
> Cc: 'pyds-dev-iYtK5bfT9M//Ad8WF/[email protected]'
> Subject: RE: [Pyds-dev] Patch to DorothyLocker
> 
> No need, but thanks for the offer! I stripped back and simplified the code,
> kept in mind that if the calling thread was the lock owner I knew I wasn't
> re-entrant, and it all behaved pretty quickly. My main cause for concern now
> is not knowing how well the LockWhiner reporting will go. I guess I should
> set the whine period to a tenth of a second to try it out. :) 
> 
> -----Original Message-----
> From: pyds-dev-admin-iYtK5bfT9M//Ad8WF/[email protected]
> [mailto:pyds-dev-admin-iYtK5bfT9M//Ad8WF/[email protected]] On Behalf Of Thomas Klaeger
> Sent: Wednesday, 22 September 2004 7:55 PM
> To: Garth T Kidd
> Cc: pyds-dev-iYtK5bfT9M//Ad8WF/[email protected]
> Subject: Re: [Pyds-dev] Patch to DorothyLocker
> 
> Is there any possibility I can help out?