Re: GitHub's CODEOWNERS to automate pull request review assignment
João Rodrigues <[email protected]> Thu, 21 Sep 2017 15:28:55 +0000
| Newsgroups | gmane.comp.python.bio.devel |
|---|---|
| Message-ID | <CAB=-b2ZT5MD7d0enF7VY04OhMXx+utsTBmL-+WC+njqu22hVzQ@mail.gmail.com> |
--===============5374897334265088249== Content-Type: multipart/alternative; boundary="001a113b00d8ba33ea0559b4c0d8" --001a113b00d8ba33ea0559b4c0d8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yeah, sure, sounds good. As for preference, I'd put it under .git, users shouldn't have to worry about it. On qui, 21/09/2017, 08:25 Peter Cock <[email protected]> wrote: > Great. > > What would you like to have automatically assigned to you > to review? Changes touching Bio/PDB/* perhaps? > > Also any preference putting the magic file CODEOWNERS > at top level, or under .github/CODEOWNERS instead? > > Peter > > P.S. Returning to the other thread, the master branch is > now protected and should only be changed via tested > pull requests: > > > http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021872= .html > > > On Thu, Sep 21, 2017 at 4:21 PM, Jo=C3=A3o Rodrigues > <[email protected]> wrote: > > Hi Peter, > > > > Sounds like a good policy to me. Also for the branch protection, makes > > perfect sense. > > > > Cheers, > > > > Jo=C3=A3o > > > > > > On qua, 20/09/2017, 14:13 Peter Cock <[email protected]> wrote: > >> > >> Hi all, > >> > >> I recently learnt of another GitHub feature which may be > >> of use for Biopython: > >> > >> https://github.com/blog/2392-introducing-code-owners > >> > >> The Galaxy Project are now trying this for their repository of > >> training materials (which is how I heard about the idea): > >> > >> https://github.com/galaxyproject/training-material/pull/539 > >> > >> The idea is we can label a default owner for files or entire > >> folders, and if a pull request changes those files, GitHub > >> will automatically assign their owner as a reviewer. > >> > >> For example, we might include the following mappings: > >> > >> Bio/Cluster/* @mdehoon > >> Bio/SeqIO/* @peterjc > >> Bio/PopGen/* @tiagoantao > >> Bio/Phylo/* @etal > >> ... > >> > >> This can be combined with the branch protection options, > >> which I proposed using recently: > >> > >> > >> > http://mailman.open-bio.org/pipermail/biopython-dev/2017-August/021861.ht= ml > >> > >> Peter > >> _______________________________________________ > >> Biopython-dev mailing list > >> [email protected] > >> http://mailman.open-bio.org/mailman/listinfo/biopython-dev > --001a113b00d8ba33ea0559b4c0d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <p dir=3D"ltr">Yeah, sure, sounds good.</p> <p dir=3D"ltr">As for preference, I'd put it under .git, users shouldn&= #39;t have to worry about it. </p> <br><div class=3D"gmail_quote"><div dir=3D"ltr">On qui, 21/09/2017, 08:25 P= eter Cock <<a href=3D"mailto:[email protected]">p.j.a.cock@googl= email.com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style= =3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Great.<b= r> <br> What would you like to have automatically assigned to you<br> to review? Changes touching Bio/PDB/* perhaps?<br> <br> Also any preference putting the magic file CODEOWNERS<br> at top level, or under .github/CODEOWNERS instead?<br> <br> Peter<br> <br> P.S. Returning to the other thread, the master branch is<br> now protected and should only be changed via tested<br> pull requests:<br> <br> <a href=3D"http://mailman.open-bio.org/pipermail/biopython-dev/2017-Septemb= er/021872.html" rel=3D"noreferrer" target=3D"_blank">http://mailman.open-bi= o.org/pipermail/biopython-dev/2017-September/021872.html</a><br> <br> <br> On Thu, Sep 21, 2017 at 4:21 PM, Jo=C3=A3o Rodrigues<br> <<a href=3D"mailto:[email protected]" target=3D"_blank">j.p.= [email protected]</a>> wrote:<br> > Hi Peter,<br> ><br> > Sounds like a good policy to me. Also for the branch protection, makes= <br> > perfect sense.<br> ><br> > Cheers,<br> ><br> > Jo=C3=A3o<br> ><br> ><br> > On qua, 20/09/2017, 14:13 Peter Cock <<a href=3D"mailto:p.j.a.cock@= googlemail.com" target=3D"_blank">[email protected]</a>> wrote:<= br> >><br> >> Hi all,<br> >><br> >> I recently learnt of another GitHub feature which may be<br> >> of use for Biopython:<br> >><br> >> <a href=3D"https://github.com/blog/2392-introducing-code-owners" r= el=3D"noreferrer" target=3D"_blank">https://github.com/blog/2392-introducin= g-code-owners</a><br> >><br> >> The Galaxy Project are now trying this for their repository of<br> >> training materials (which is how I heard about the idea):<br> >><br> >> <a href=3D"https://github.com/galaxyproject/training-material/pull= /539" rel=3D"noreferrer" target=3D"_blank">https://github.com/galaxyproject= /training-material/pull/539</a><br> >><br> >> The idea is we can label a default owner for files or entire<br> >> folders, and if a pull request changes those files, GitHub<br> >> will automatically assign their owner as a reviewer.<br> >><br> >> For example, we might include the following mappings:<br> >><br> >> Bio/Cluster/* @mdehoon<br> >> Bio/SeqIO/* @peterjc<br> >> Bio/PopGen/* @tiagoantao<br> >> Bio/Phylo/* @etal<br> >> ...<br> >><br> >> This can be combined with the branch protection options,<br> >> which I proposed using recently:<br> >><br> >><br> >> <a href=3D"http://mailman.open-bio.org/pipermail/biopython-dev/201= 7-August/021861.html" rel=3D"noreferrer" target=3D"_blank">http://mailman.o= pen-bio.org/pipermail/biopython-dev/2017-August/021861.html</a><br> >><br> >> Peter<br> >> _______________________________________________<br> >> Biopython-dev mailing list<br> >> <a href=3D"mailto:[email protected]" target=3D"_b= lank">[email protected]</a><br> >> <a href=3D"http://mailman.open-bio.org/mailman/listinfo/biopython-= dev" rel=3D"noreferrer" target=3D"_blank">http://mailman.open-bio.org/mailm= an/listinfo/biopython-dev</a><br> </blockquote></div> --001a113b00d8ba33ea0559b4c0d8-- --===============5374897334265088249== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Biopython-dev mailing list [email protected] http://mailman.open-bio.org/mailman/listinfo/biopython-dev --===============5374897334265088249==--