Re: [PATCH] C extension fails to build on Python 2.5 because of PyUnicode_FromFormat

Arnaud Fontaine <[email protected]> Wed, 31 Mar 2010 11:26:01 +0200

Newsgroups	gmane.comp.python.cheetah
Organization	Debian
Message-ID	<[email protected]>

Hi,

    > Aha, good  catch Arnaud, I had experienced a  similar quirk when I
    > ported another C-extension that I  maintain to run on Python 2.4 -
    > 3.1, I'll squeeze an update out tonight or tomorrow :)

Does the patch look alright? I have already uploaded a Debian package of
python-cheetah 2.4.2.1  which includes this patch. So  don't worry about
the update  ;), especially because I seem  to be the only  one to report
such issue.

    >> BTW, my question may be silly but I'm wondering why `newExcValue'
    >>      reference       returned      by      PyUnicode_FromFormat()
    >>   (wrapInternalNotFoundException()  function)  is   never  DECREF
    >>   whereas   it   is   in  setNotFoundException()   function   for
    >> `exceptionStr'.  Just curious ;)...

Any thoughts about that? ;)

Cheers,
Arnaud

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev