Re: Updated patch to quote delimiter and null characters in copy_* functions

Federico Di Gregorio <fog-NGVKUo/i/[email protected]>
Newsgroups gmane.comp.python.db.psycopg.devel
Organization initd.org
Message-ID <[email protected]>
Il giorno mar, 23/09/2008 alle 14.38 +1000, Alejandro Dubrovsky ha scritto:
> This patch enlarges the default size of the copy buffer and also checks
> to see if the copy query got truncated.  ie copy_to(somefile, '(some
> long query)') is very handy and I went crazy with it until I broke the
> first patch.

Your patch seems fine to me and it surely add needed functionality but
I don't like to have to different quoting functions. Do you have the
time to move all functionality of qstring_escape() to
psycopg_internal_escape_string() and then have qstring_escape call that?
Also note that the patch you sent does not include utils.h and utils.c.

federico

-- 
Federico Di Gregorio                         http://people.initd.org/fog
Debian GNU/Linux Developer                                [email protected]
INIT.D Developer                                           fog-NGVKUo/i/[email protected]
 Ubuntu is an ancient African word meaning "I can't configure Debian".
                                                     -- somewhere on IRC

_______________________________________________
Psycopg mailing list
Psycopg-IAPFreCvJWPBWskQ1e/[email protected]
http://lists.initd.org/mailman/listinfo/psycopg
signature.asc (application/pgp-signature, 197 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkjY8FkACgkQvcCgrgZGjetRxgCeNovyBcEsCi2DSRUv7XRLzbE0
k8wAoM92I4GAPwx5l7hffiYVlaGPbLFx
=JkW2
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.