PATCH - reference leak in PgConnection
Andrew McNamara <[email protected]> Sat, 28 Apr 2007 17:34:56 +1000
| Newsgroups | gmane.comp.python.db.pypgsql.user |
|---|---|
| Message-ID | <[email protected]> |
This is a multipart MIME message. --==_Exmh_1177745693_23210 Content-Type: text/plain; charset=us-ascii This patch, against the CVS HEAD, fixes a reference leak in the handling of the PgConnection_Type - the cinfo element reference was not being released in PgConnection_dealloc. The patch also initialises the PgConnection structure as I don't think you can count on the return from PyObject_New being zeroed out. If you would rather, grant my SF account commit privs, and I'll apply these myself (username "andrewmcnamara"). -- Andrew McNamara, Senior Developer, Object Craft http://www.object-craft.com.au/ --==_Exmh_1177745693_23210 Content-Type: application/octet-stream ; name="pgconnectionleak-patch" Content-Description: pgconnectionleak-patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pgconnectionleak-patch" SW5kZXg6IHBnY29ubmVjdGlvbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290 L3B5cGdzcWwvcHlwZ3NxbC9wZ2Nvbm5lY3Rpb24uYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS4yNApkaWZmIC11IC1yMS4yNCBwZ2Nvbm5lY3Rpb24uYwotLS0gcGdjb25uZWN0aW9uLmMJ MjYgU2VwIDIwMDUgMDg6MDg6MTcgLTAwMDAJMS4yNAorKysgcGdjb25uZWN0aW9uLmMJMjgg QXByIDIwMDcgMDc6Mjk6MzIgLTAwMDAKQEAgLTE0MCw2ICsxNDAsMTIgQEAKIAljaGFyICpy OwogCiAJc2VsZi0+Y29ubiA9IGNvbm47CisKKyAgICAgICAgc2VsZi0+aG9zdCA9IHNlbGYt PnBvcnQgPSBzZWxmLT5kYiA9IHNlbGYtPm9wdGlvbnMgPSBOVUxMOworICAgICAgICBzZWxm LT50dHkgPSBzZWxmLT51c2VyID0gc2VsZi0+cGFzcyA9IHNlbGYtPmJlUElEID0gTlVMTDsK KyAgICAgICAgc2VsZi0+c29ja2V0ID0gc2VsZi0+dmVyc2lvbiA9IHNlbGYtPm5vdGljZXMg PSBOVUxMOworICAgICAgICBzZWxmLT5jaW5mbyA9IHNlbGYtPmRlYnVnID0gTlVMTDsKKwog CWlmICgoc2VsZi0+bm90aWNlcyA9IFB5X0J1aWxkVmFsdWUoIltdIikpID09IChQeU9iamVj dCAqKU5VTEwpCiAJewogCSAgICBQeV9YREVDUkVGKHNlbGYpOwpAQCAtMjE3LDYgKzIyMyw3 IEBACiAgICAgUHlfWERFQ1JFRihzZWxmLT5zb2NrZXQpOwogICAgIFB5X1hERUNSRUYoc2Vs Zi0+dmVyc2lvbik7CiAgICAgUHlfWERFQ1JFRihzZWxmLT5ub3RpY2VzKTsKKyAgICBQeV9Y REVDUkVGKHNlbGYtPmNpbmZvKTsKICAgICBQeV9YREVDUkVGKHNlbGYtPmRlYnVnKTsKIAog ICAgIFB5T2JqZWN0X0RlbChzZWxmKTsK --==_Exmh_1177745693_23210 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ --==_Exmh_1177745693_23210 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Pypgsql-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pypgsql-users --==_Exmh_1177745693_23210--