Re: Last patch breaks Py 2.3 compatibility

On Thu, 2011-07-07 at 12:01 -0500, Ian Bicking wrote:
> Oh, are we talking about Python 3 porting too?  Huh, I haven't been
> keeping track.  Another guy also worked on Python 3 porting, as a
> prerequisite for porting SQLObject.  His work is here:
> https://bitbucket.org/fetchinson/formencode-py3k/overview -- I just
> read the changes, but it looked fairly complete to me.

My effort was a sort of a semi-accidental port to Python 3, driven
mainly by curiosity and self-interest. A casual application of 2to3
showed a lot of promise, suggesting that just a few hard-coded
sys.version switches were required to cover the gaps. formencode has the
advantage that it's pretty much self-contained.

I was aware of Daniel Fetchinson's work on a port but, as I didn't/don't
have much familiarity with the codebase, I wasn't really able to assess
how much of the task remained to be done. I couldn't quite make out
Daniel's intentions for the port because his choosing to use the 2.4
collections module would definitely rule out support for 2.3 and yet the
mainstream commit comments indicated that support for 2.3 was still an
existing requirement. AFAIK, there's no a priori reason why a
2to3-driven port would rule out support for Python 2.3, so I ploughed my
own furrow.

As it transpired, I managed to solve the compilation issue and I can
confirm that all the tests pass with Python 2.3.

I've inserted a separate Python2.3 nosetests run into the hudson build
script. It won't run under tox because that, via virtualenv, requires
2.4's subprocess module

Supporting 2.3 does carry some disproportionate effort but it would seem
that a 2to3 solution doesn't necessarily have to have any impact on that
issue either way - but more extensive test coverage would help clarify
that, I s'pose.

-- 
Graham Higgins

http://bel-epa.com/gjh/

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

_______________________________________________
FormEncode-discuss mailing list
FormEncode-discuss-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/formencode-discuss

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iF4EABEIAAYFAk4WbqEACgkQMBjI+1utKYsNywD+NsV1C7/g1teDsGn/jiywMRoD
CwDhzRN2GF5QvfctOhYA/1F7yuXpYu6r0xJiaILntbV67JaKiGhXuMvNtsCts1wR
=GlHb
-----END PGP SIGNATURE-----