[ python-Patches-1731049 ] Pruning threading.py from asserts

"SourceForge.net" <[email protected]>
Newsgroups gmane.comp.python.patches
Message-ID <[email protected]>
Patches item #1731049, was opened at 2007-06-04 18:17
Message generated for change (Comment added) made by collinwinter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1731049&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Library (Lib)
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Björn Lindqvist (sonderblade)
Assigned to: Nobody/Anonymous (nobody)
Summary: Pruning threading.py from asserts

Initial Comment:
threading.py heavily uses asserts to protect against undefined behavior. That's no good, because asserts are removed when Python is run with the -O option. 

The suggested fix is to replace all, or almost all, assertions with more robust RuntimeErrors. 

The whole change is split in two parts. First a patch which adds tests for the new behavior. Then a patch which fixes threading.py and adds the necessary documentation.

----------------------------------------------------------------------

>Comment By: Collin Winter (collinwinter)
Date: 2007-06-05 20:17

Message:
Logged In: YES 
user_id=1344176
Originator: NO

Applied to trunk as r55785. Thanks!

----------------------------------------------------------------------

Comment By: Björn Lindqvist (sonderblade)
Date: 2007-06-04 19:05

Message:
Logged In: YES 
user_id=51702
Originator: YES

File Added: threading.py-use-real-exceptions.py

----------------------------------------------------------------------

Comment By: Björn Lindqvist (sonderblade)
Date: 2007-06-04 18:56

Message:
Logged In: YES 
user_id=51702
Originator: YES

File Added: test_threading-check-for-runtimeerrors2.patch

----------------------------------------------------------------------

Comment By: Björn Lindqvist (sonderblade)
Date: 2007-06-04 18:19

Message:
Logged In: YES 
user_id=51702
Originator: YES

File Added: test_threading-check-for-runtimeerrors.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1731049&group_id=5470

_______________________________________________
Patches mailing list
[email protected]
http://mail.python.org/mailman/listinfo/patches
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.