[ python-Patches-1757774 ] struni: fix str/bytes errors for test_oldmailbox
"SourceForge.net" <[email protected]> Fri, 20 Jul 2007 15:46:29 -0700
| Newsgroups | gmane.comp.python.patches |
|---|---|
| Message-ID | <[email protected]> |
Patches item #1757774, was opened at 2007-07-20 16:07 Message generated for change (Comment added) made by avassalotti You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1757774&group_id=5470 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Library (Lib) Group: Python 3000 >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Alexandre Vassalotti (avassalotti) Assigned to: Nobody/Anonymous (nobody) Summary: struni: fix str/bytes errors for test_oldmailbox Initial Comment: This patch replaces isinstance(s, str) by isinstance(s, bytes) for checking non-unicode strings. It also makes _ProxyFile.get_file() open files in "standard" mode (non-binary). ---------------------------------------------------------------------- >Comment By: Alexandre Vassalotti (avassalotti) Date: 2007-07-20 18:46 Message: Logged In: YES user_id=1826340 Originator: YES Superseded by patch #1757839 Changing status to closed. ---------------------------------------------------------------------- Comment By: Alexandre Vassalotti (avassalotti) Date: 2007-07-20 16:49 Message: Logged In: YES user_id=1826340 Originator: YES My change to _ProxyFile.get_file() is bad idea. Please wait for my updated patch that will also fix test_mailbox. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305470&aid=1757774&group_id=5470