Re: Patch: Update RuleDispatch for python-2.7
"P.J. Eby" <pje-Wh6+Hckhi6HFNGf7iClzIwC/[email protected]> Sun, 01 Aug 2010 14:08:14 -0400
| Newsgroups | gmane.comp.python.peak |
|---|---|
| Message-ID | <[email protected]> |
At 10:01 AM 8/1/2010 -0400, Toshio Kuratomi wrote: >In Fedora we've recently upgraded from python-2.6 to python-2.7. In doing >so we found that the unittests for RuleDispatch were failing. The failures >seem to be legitimate bugs in ruledispatch so I've updated the code to fix >them. I'm attaching a patch for your perusal. I've checked in something that should be equivalent, and updated the testlist_comp in PEAK-Rules as well. Thanks! Btw, it's highly recommended that people switch to PEAK-Rules, as it is better tested, has better performance (especially if you're just using type checks without full predicate dispatch), and its internals are far more documented and extensible than RuleDispatch. For ease in porting, there's even a peak.rules.dispatch module that provides a partial API emulation for RuleDispatch. If you're using an API that's not supported by the emulation, I'd appreciate a heads-up so I can give it implementation priority, or at least document how to translate what you're doing to the new API. Come to think of it, I should probably slap that information into RuleDispatch's README, so it'll go into your next release... There, done and done. ;-)