Re: Pyro 4.14 released!

Irmen de Jong <[email protected]>
Newsgroups gmane.comp.python.pyro
Message-ID <[email protected]>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9-5-2012 1:36, Todd Williamson wrote:
> Irmen,
> 
> I tried Pyro 4.14 for my work and the hanging bug still occurs.  I have reverted
> back to 4.13 and am using the THREADPOOL_MINTHREAD == THREADPOOL_MAXTHREAD fix to
> keep things running solid.  If you need any assistance testing a future fix of this
> bug please let me know.
> 
> Todd

Hmm, that's very weird. I changed the following in threadpool.py:

@@ -73,7 +77,8 @@
         Returns True if a worker spawned, False if the pool is already full.
         """
         with self.lock:
- -            if len(self.pool) < Pyro4.config.THREADPOOL_MAXTHREADS:
+            # if len(self.pool) < Pyro4.config.THREADPOOL_MAXTHREADS:  # @todo
temporary workaround: see next line
+            if len(self.pool) < Pyro4.config.THREADPOOL_MINTHREADS:   # @todo
temporary workaround for threadpool scale problem: stick with fixed number of threads
for now (THREADPOOL_MINTHREADS)
                 worker = self.workerFactory()
                 self.pool.add(worker)
                 worker.start()

Which is the only use of THREADPOOL_MAXTHREADS in the source (other than setting the
config item itself).

This should be identical to manually setting  THREADPOOL_MINTHREADS==
THREADPOOL_MAXTHREADS.

Can't explain why you're still seeing the problem with this change in the code... :-/

Irmen


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPqba3AAoJEHC9o7RHFlf2aIAH/jfay1A/jrP+JUrudakD/d9u
PX1KHibvCe4RKrYnUIy8i/3ui7Ivc7CLjaXN2/9ukGtHBZf9JV5WTR/9PuORxB6r
2knEveRZady+k4ZtCu9cTWYQYYQ/CPj6fLJXfZAVz8h4F84Qvceg0knDBqiaZUnI
bnzMKY0k7V1uTr3WQHypKOllKLbYRq3lSDzFGdPOB53ZsBWoxRVfcU32Rn4I9UFq
fPqwAHDX3c86ciZnA0e6Mq09PTKVbmZO57hUyv5NjWXLk2op048NeGy+RUpg+DYG
bUfnAjkvhxqGlBxOjrT2hEX1iArFvUmPXB99Tmf/+EIv/4xHiBhII+cdEElmyh4=
=uHtc
-----END PGP SIGNATURE-----

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.