Re: [Divmod-commits] r6554 - Maintaining the spacing exactly in comments is sometimes critical (IE

On Fri, 12 May 2006 17:01:39 -0400, [email protected] wrote:
>
>Author: mg
>Date: Fri May 12 17:01:39 2006
>New Revision: 6554
>
>Modified:
>   trunk/Nevow/nevow/flat/flatsax.py
>   trunk/Nevow/nevow/test/test_flatsax.py
>Log:
>Maintaining the spacing exactly in comments is sometimes critical (IE
>conditional comments) but flatsax was adding an extra space before and after
>the comment content.

Branch/Ticket/Reviewer?

There's actually a ticket outstanding for this issue already, but I notice you didn't apply the patch attached to it :)

I've looked over the diff you committed and it looks okay, so no need to revert or anything, but please follow the procedure on <http://divmod.org/trac/wiki/UltimateQualityDevelopmentSystem> for future changes.  One reason I've held off applying the patch from #627 is that I've been considering whether to add support for a special iecomment tag.  It seems like this would be better than just changing the render-style of all existing comments, but I haven't had time to try to implement it.

Jean-Paul