Re: Detaching life fragments bug - how do I proceed

Done, ticket #3020

AFAIK the review process is somewhat different with nevow, I was no able 
to set the ticket to a review state.

On the server test side I added a proposal for an additional test, the 
client side tests running with

trial  nevow.test.livetest_athena

deliver the following traceback

    return klass(methodName)
Traceback (most recent call last):
    File "C:\proj\twisted\bin\trial", line 22, in <module>
      run()
    File "C:\proj\twisted\twisted\scripts\trial.py", line 359, in run
      suite = _getSuite(config)
    File "C:\proj\twisted\twisted\scripts\trial.py", line 317, in _getSuite
      return loader.loadByNames(config['tests'], recurse)
    File "C:\proj\twisted\twisted\trial\runner.py", line 655, in loadByNames
      for thing in set(things)]
    File "C:\proj\twisted\twisted\trial\runner.py", line 613, in 
loadAnything
      return self.loadModule(thing)
    File "C:\proj\twisted\twisted\trial\runner.py", line 486, in loadModule
      suite.addTest(self.loadClass(testClass))
    File "C:\proj\twisted\twisted\trial\runner.py", line 506, in loadClass
      for name in names])
    File "C:\proj\twisted\twisted\trial\runner.py", line 439, in sort
      return dsu(xs, self.sorter)
    File "C:\proj\twisted\twisted\python\util.py", line 568, in dsu
      L2 = [(key(e), i, e) for (i, e) in zip(range(len(list)), list)]
    File "C:\proj\twisted\twisted\trial\runner.py", line 319, in name
      theName = thing.name
AttributeError: 'AsyncExceptionFromServer' object has no attribute 'name'

Thxs, Werner


On 26.07.2010 16:20, Tristan Seligmann wrote:
> On Mon, Jul 26, 2010 at 11:12 AM, Werner Thie<[email protected]>  wrote:
>> Any advice on how to proceed with moving the solution below to the following
>> problem into nevow trunk?
>
> I'd suggest creating a ticket with the description of the problem,
> attaching the patch, and giving it the keyword "review". Note that the
> patch will need unit tests before it can be merged; if you don't have
> the time to add tests, please create the ticket anyway, so the problem
> / patch doesn't get lost completely.
>
> See http://twistedmatrix.com/trac/wiki/ReviewProcess for more info.