Re: Patch to support tables with oversize cells

Robin Becker <[email protected]> Sat, 4 Jun 2022 10:20:07 +0100
Newsgroups gmane.comp.python.reportlab.user
Message-ID <[email protected]>
On 01/06/2022 12:33, Lennart Regebro wrote:
> Yes, two small bugs in height alignments that didn't show up in any
> previous test. Good find.
> 
> 
..........

Hi Lennart,

I took a look at v9 and it seems fine. I'll try a few more tests and probably commit Monday.

I made some minor changes to the patch.

0) I inlined the two matrixcopy calls

1) I moved the _cellvalues copy into the two different paths so the doInRowSplit test looks like

if not doInRowSplit:
     T = self
     data = self._cellvalues
else:
     data = [_[:] for _ in self._cellvalues]

I don't think the copy is required in the not doInRowSplit case; that lines up with the original code and my lines 
changed test code agrees.
-- 
Robin Becker