Re: Fast versions of scipy.io.mmread/write

Ralf Gommers <[email protected]> Thu, 13 Jul 2023 13:10:21 +0200
Newsgroups gmane.comp.python.scientific.devel
Message-ID <CABL7CQj3TigJweh2vsJhDwj=t4o7=snGNfJ97Mt9T3FMWvZ-qA@mail.gmail.com>
On Tue, Jul 11, 2023 at 5:20 AM <[email protected]> wrote:

> Thanks for the support everyone, we now have a PR:
> https://github.com/scipy/scipy/pull/18631
>
> I included a memory benchmark for those wondering about memory usage. The
> measured peak RSS is the same as the current Python version, except it's
> lower when writing coordinate matrices. This is because _mmio copies the
> values array, FMM does not.
>
> Feedback welcome!
>

Thanks Adam, this looks pretty good!

To everyone else: this is a fairly sizeable amount of C++ code which adds a
little bit to our binary size (probably ~2%) and build time (probably ~8%),
but the performance gains, extra features and better maintained code are
probably worth it. I'm still reviewing and would like to get build time
impact a little lower still; if anyone else is interested please weigh in
though.

Cheers,
Ralf

_______________________________________________
SciPy-Dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/scipy-dev.python.org/
Member address: [email protected]