Re: Let's make it official then... recommend max line length 88

+1 from me, aligns with default for `black` which is used in many places
nowadays:

https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length

Eric


On Tue, Sep 5, 2023 at 12:01 PM <[email protected]> wrote:

> Why 88?
>
> It sounds a bit arbitrary to me to let a "random" CI tool make the
> policies.
> 9 characters does not look to me worth the effort.
>
> (Not that I really care for scipy style, but I don't see a reason to make
> this a new convention in scientific python.)
>
> Josef
>
>
>
> On Tue, Sep 5, 2023 at 11:47 AM Warren Weckesser <
> [email protected]> wrote:
>
>> SciPy is documented to follow the PEP 8 style guidelines; see
>>
>> https://docs.scipy.org/doc/scipy/dev/contributor/pep8.html#pep8-scipy
>>
>> PEP 8 recommends a maximum line length of 79 characters. The degree of
>> care with which we follow this guideline has varied quite a bit over the
>> years, and there is currently a lot code where the guideline is violated.
>> Lately, in particular, the enforcement of this guideline has been relaxed,
>> and folks seem to be settling on 88 characters as a reasonable maximum.
>> This is partly a side effect of the replacement of `pycodestyle` in CI with
>> `ruff`; the default maximum line length in `ruff` is 88. This means new
>> lines of code with lengths between 80 and 88 are not being flagged in CI.
>> (I don't recall if CI currently fails with lines longer than 88 characters.)
>>
>> If everyone is satisfied with a maximum of 88 characters, let's make it
>> official and update our developer documents to state this explicitly.
>>
>> What do you say, yea or nay?
>>
>> Warren
>> _______________________________________________
>> SciPy-Dev mailing list -- [email protected]
>> To unsubscribe send an email to [email protected]
>> https://mail.python.org/mailman3/lists/scipy-dev.python.org/
>> Member address: [email protected]
>>
> _______________________________________________
> SciPy-Dev mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
> https://mail.python.org/mailman3/lists/scipy-dev.python.org/
> Member address: [email protected]
>

_______________________________________________
SciPy-Dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/scipy-dev.python.org/
Member address: [email protected]