Re: Let's make it official then... recommend max line length 88

Having a documented length to which we stick would make a tangible improvement to the new contributor experience.

> SciPy is documented to follow the PEP 8 style guidelines

I can attest to reading this, making changes to obey the 79 character limit, and later undoing the changes once I found out that up to 88 is (currently) 'ok'. I have no preference for a certain number of characters, but 88 seems to be favoured by quite a few maintainers and would require no changes to what we currently do.

> (Not that I really care for scipy style, but I don't see a reason to make
> this a new convention in scientific python.)

Would you be happy with Warren's stated scope (updating the SciPy developer docs), as long as it isn't intended as a convention to be followed by the whole scientific python ecosystem?

If it seems possible that in the near future the ecosystem will adopt a different convention (79, 80 or some other number that isn't 88), then I can see an argument for holding off here.

If not, then I see no reason to block this improvement to the new contributor experience (which is a correction to inaccurate documentation, given that "there is currently a lot [of] code where the guideline is violated" and it is not currently enforced at all).

Cheers,
Lucas (@lucascolley)
_______________________________________________
SciPy-Dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/scipy-dev.python.org/
Member address: [email protected]