Re: Silly warnings from python-SunOS-5.8-sun4d-fafner

Anders Qvist <[email protected]> writes:

> The file also has its atime updated by a make command, so it's likely
> to be used.
> 
>   #ifdef _AIX
>   extern int fdatasync(int);
>   #endif
> 
> ... solves the problem, but isn't very beautiful. 

Can you try this patch? (+ associated changes to configure &
pyconfig.h.in, which I can send you if they're hard for you to
generate).

Index: configure.in
===================================================================
RCS file: /cvsroot/python/python/dist/src/configure.in,v
retrieving revision 1.335
diff -c -r1.335 configure.in
*** configure.in	20 Jul 2002 08:51:52 -0000	1.335
--- configure.in	22 Jul 2002 10:41:32 -0000
***************
*** 1656,1661 ****
--- 1656,1662 ----
    )
  )
  
+ AC_CHECK_DECLS([fdatasync])
  
  # On OSF/1 V5.1, getaddrinfo is available, but a define
  # for [no]getaddrinfo in netdb.h. 
Index: Modules/posixmodule.c
===================================================================
RCS file: /cvsroot/python/python/dist/src/Modules/posixmodule.c,v
retrieving revision 2.244
diff -c -r2.244 posixmodule.c
*** Modules/posixmodule.c	15 Jul 2002 16:10:55 -0000	2.244
--- Modules/posixmodule.c	22 Jul 2002 10:41:33 -0000
***************
*** 887,894 ****
  
  #ifdef HAVE_FDATASYNC
  
! #ifdef __hpux
! extern int fdatasync(int); /* On HP-UX, in libc but not in unistd.h */
  #endif
  
  PyDoc_STRVAR(posix_fdatasync__doc__,
--- 887,894 ----
  
  #ifdef HAVE_FDATASYNC
  
! #if !HAVE_DECL_FDATASYNC
! extern int fdatasync(int);
  #endif
  
  PyDoc_STRVAR(posix_fdatasync__doc__,

Is Martin here?  I'd like him to look at this before I checked it in...

Cheers,
M.

-- 
  The use of COBOL cripples the mind; its teaching should, therefore,
  be regarded as a criminal offence.
           -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5