Re: Fixing debian bug 605185

On Tue, Nov 01, 2011 at 03:59:23PM +0200, Neil Muller wrote:
> Debian currently has a bug against sqlobject for an insecure use of
> PYTHONPATH in the docs/rebuild script -
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=605185 . While it is
> a minor issue, it's easy enough to do the right thing, so seems worth
> fixing.
> 
> Patch attached.
> 
> -- 
> Neil Muller
> [email protected]

   Thank you!

> I've got a gmail account. Why haven't I become cool?

> Index: docs/rebuild
> ===================================================================
> --- docs/rebuild	(revision 4465)
> +++ docs/rebuild	(working copy)
> @@ -3,7 +3,7 @@
>  here=`pwd`
>  parent=`dirname $here`
>  echo "Adding $parent to \$PYTHONPATH"
> -export PYTHONPATH=$parent:$PYTHONPATH
> +export PYTHONPATH=$parent${PYTHONPATH:+:$PYTHONPATH}

   Strange syntax ${PYTHONPATH:+:$PYTHONPATH} . Are you sure? Shouldn't
it be just ${PYTHONPATH:+$PYTHONPATH} ?

Oleg.
-- 
     Oleg Broytman            http://phdru.name/            [email protected]
           Programmers don't die, they just GOSUB without RETURN.

------------------------------------------------------------------------------
RSA® Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1