orderBy isinstance str check

Andrew Trusty <[email protected]> Sat, 25 Oct 2014 11:52:37 -0600
Newsgroups gmane.comp.python.sqlobject
Message-ID <CAKEEeogeS2y4-EQjd7Ud0kCY2X3JSUdC0Bu-SAfk63Fc177rVw@mail.gmail.com>
Hi,

I recently discovered that some of my code was passing unicode strings to
orderBy and that this worked as long as the strings didn't start with "-".
When they did start with "-", the _mungeOrderBy check (line 69 in
sresults.py) didn't detect the "-" because the strings were of type unicode
and not type str and _mungeOrderBy checks for str and not basestring.

I was just wondering if this was on purpose or not as it looks like there
are other places in the sqlobject code that do check for type basestring.

Andrew

------------------------------------------------------------------------------

_______________________________________________
sqlobject-discuss mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss