New submission from glyph <[email protected]>:
This regression appears to have been introduced by r26534. The test coverage introduced in that revision is apparently insufficient.
{{{
$ conch twistedmatrix.com
/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/userauth.py:660: DeprecationWarning: Returning a string from SSHUserAuthClient.getPublicKey() is deprecated since Twisted 9.0. Return a keys.Key() instead.
DeprecationWarning)
Traceback (most recent call last):
File "/home/glyph/Projects/Twisted/trunk/twisted/internet/selectreactor.py", line 146, in _doReadOrWrite
why = getattr(selectable, method)()
File "/home/glyph/Projects/Twisted/trunk/twisted/internet/tcp.py", line 460, in doRead
return self.protocol.dataReceived(data)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/transport.py", line 313, in dataReceived
self.dispatchMessage(messageNum, packet[1:])
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/transport.py", line 335, in dispatchMessage
messageNum, payload)
--- <exception caught here> ---
File "/home/glyph/Projects/Twisted/trunk/twisted/python/log.py", line 84, in callWithLogger
return callWithContext({"system": lp}, func, *args, **kw)
File "/home/glyph/Projects/Twisted/trunk/twisted/python/log.py", line 69, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File "/home/glyph/Projects/Twisted/trunk/twisted/python/context.py", line 59, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/home/glyph/Projects/Twisted/trunk/twisted/python/context.py", line 37, in callWithContext
return func(*args,**kw)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/service.py", line 44, in packetReceived
return f(packet)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/userauth.py", line 533, in ssh_USERAUTH_PK_OK
return func(packet)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/userauth.py", line 547, in ssh_USERAUTH_PK_OK_publickey
d = self.signData(publicKey, b)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/client/default.py", line 193, in signData
return self.keyAgent.signData(publicKey, signData)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/agent.py", line 102, in signData
req = NS(blob)
File "/home/glyph/Projects/Twisted/trunk/twisted/conch/ssh/common.py", line 42, in NS
return struct.pack('!L',len(t)) + t
exceptions.TypeError: object of type 'Key' has no len()
Connection to twistedmatrix.com closed.
}}}
Please fix ASAP; I am not reverting the branch as there are now conflicts in trunk, but I'll go to the trouble of resolving them if this isn't a trivial fix.
----------
Type : regression
Component: conch
Keywords :
Priority : highest
Nosy :
----------
http://twistedmatrix.com/trac/ticket/3809
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.