Assorted code in Twisted passes a mode including "b" to FilePath.open
[email protected] Tue, 12 Jan 2010 14:34:14 -0000
| Newsgroups | gmane.comp.python.twisted.bugs |
|---|---|
| Message-ID | <[email protected]> |
New submission from exarkun <[email protected]>: `FilePath.open` enforces that the mode is binary, so it's redundant to pass in a mode that includes "b". This worked anyway, though, as most systems treat "rb" and "rbb" the same. However, ivan pointed out that Python 2.7 on Windows appears to treat "rbb" as an error. As there's no reason to pass a "b" in in the first place, we should stop doing it in Twisted wherever we are now. This seems mainly to be in `twisted/protocols/ftp.py` and `twisted/plugin.py` ---------- Type : defect Component: core Keywords : Priority : normal Nosy : ---------- http://twistedmatrix.com/trac/ticket/4207