r46935 - review comments

Author: hawkowl
Date: Sun Mar  6 23:10:38 2016
New Revision: 46935

Added:
   branches/sdist-use-7985-4/twisted/topfiles/7985.feature
Modified:
   branches/sdist-use-7985-4/MANIFEST.in
   branches/sdist-use-7985-4/setup3.py

Log:
review comments

Modified: branches/sdist-use-7985-4/MANIFEST.in
==============================================================================
--- branches/sdist-use-7985-4/MANIFEST.in	(original)
+++ branches/sdist-use-7985-4/MANIFEST.in	Sun Mar  6 23:10:38 2016
@@ -1,3 +1,12 @@
+# This file dictates what goes into a sdist tarball.
+# As a release tarball, we want to include:
+#  - All of the library code.
+#  - All the useful documentation (but not the super historic stuff)
+#  - All of the test files, so that the tests can be run on an installed copy.
+# We do not want to include:
+#  - Release management files (e.g. topfiles)
+#  - Things only useful when running from a source checkout (_preamble.py)
+
 # Do not include the old topfiles, or news fragments
 recursive-exclude twisted *.misc *.bugfix *.doc *.feature *.removal
 recursive-exclude twisted NEWS README topfiles
@@ -7,12 +16,16 @@
 recursive-include docs README
 include NEWS README.rst INSTALL.rst CONTRIBUTING LICENSE code_of_conduct.md
 
-# Exclude admin things
+# Exclude admin scripts and things only useful when running from a source checkout
+exclude bin/_preamble.py
 exclude admin
 exclude bin/admin
 recursive-exclude admin *
 recursive-exclude bin/admin *
 
+# Include test-running utilities for downstream packagers
+include tox.ini .coveragerc
+
 # Python 3 setup file
 include setup3.py
 
@@ -24,9 +37,6 @@
 # Some extras
 recursive-include twisted *.glade *.pxi *.h *.c *.bat *.g *.pyx *.zsh *.txt
 
-# Dev tools
-include tox.ini bin/_preamble.py .coveragerc
-
 # Docs
 include docs/fun/lightbulb
 recursive-include docs/historic/Quotes *

Modified: branches/sdist-use-7985-4/setup3.py
==============================================================================
--- branches/sdist-use-7985-4/setup3.py	(original)
+++ branches/sdist-use-7985-4/setup3.py	Sun Mar  6 23:10:38 2016
@@ -35,7 +35,10 @@
 
 
 class PickyBuildScripts(build_scripts):
-
+    """
+    A version of build_scripts which doesn't install the scripts that aren't
+    yet ported to Python 3.
+    """
     def copy_scripts(self):
         from twisted.python.dist3 import portedScripts
         self.scripts = portedScripts