r47318 - some review comments

Author: hawkowl
Date: Mon Apr 25 19:41:55 2016
New Revision: 47318

Modified:
   branches/cov-subprocess-8266-2/admin/_copy.py
   branches/cov-subprocess-8266-2/admin/zz_coverage.pth
   branches/cov-subprocess-8266-2/twisted/internet/test/test_process.py
   branches/cov-subprocess-8266-2/twisted/test/test_process.py
   branches/cov-subprocess-8266-2/twisted/test/test_stdio.py

Log:
some review comments

Modified: branches/cov-subprocess-8266-2/admin/_copy.py
==============================================================================
--- branches/cov-subprocess-8266-2/admin/_copy.py	(original)
+++ branches/cov-subprocess-8266-2/admin/_copy.py	Mon Apr 25 19:41:55 2016
@@ -1,3 +1,7 @@
+"""
+A cross-platform copying tool that supports globbing.
+"""
+
 import sys
 import glob
 import shutil

Modified: branches/cov-subprocess-8266-2/admin/zz_coverage.pth
==============================================================================
--- branches/cov-subprocess-8266-2/admin/zz_coverage.pth	(original)
+++ branches/cov-subprocess-8266-2/admin/zz_coverage.pth	Mon Apr 25 19:41:55 2016
@@ -1 +1 @@
-import coverage; coverage.process_startup()
+import coverage; coverage.process_startup() # A .pth hack to load coverage process startup in subprocesses spawned by Python, see http://nedbatchelder.com/blog/201001/running_code_at_python_startup.html

Modified: branches/cov-subprocess-8266-2/twisted/internet/test/test_process.py
==============================================================================
--- branches/cov-subprocess-8266-2/twisted/internet/test/test_process.py	(original)
+++ branches/cov-subprocess-8266-2/twisted/internet/test/test_process.py	Mon Apr 25 19:41:55 2016
@@ -3,6 +3,9 @@
 
 """
 Tests for implementations of L{IReactorProcess}.
+
+@var properEnv: A copy of L{os.environ} which has L{bytes} keys/values on POSIX
+    platforms and native L{str} keys/values on Windows.
 """
 
 from __future__ import division, absolute_import, print_function

Modified: branches/cov-subprocess-8266-2/twisted/test/test_process.py
==============================================================================
--- branches/cov-subprocess-8266-2/twisted/test/test_process.py	(original)
+++ branches/cov-subprocess-8266-2/twisted/test/test_process.py	Mon Apr 25 19:41:55 2016
@@ -12,6 +12,9 @@
     cause spurious failures if this value is pushed too high.  U{Please see
     this ticket for a discussion of how we arrived at its current value.
     <http://twistedmatrix.com/trac/ticket/3404>}
+
+@var properEnv: A copy of L{os.environ} which has L{bytes} keys/values on POSIX
+    platforms and native L{str} keys/values on Windows.
 """
 
 from __future__ import division, absolute_import

Modified: branches/cov-subprocess-8266-2/twisted/test/test_stdio.py
==============================================================================
--- branches/cov-subprocess-8266-2/twisted/test/test_stdio.py	(original)
+++ branches/cov-subprocess-8266-2/twisted/test/test_stdio.py	Mon Apr 25 19:41:55 2016
@@ -3,6 +3,9 @@
 
 """
 Tests for L{twisted.internet.stdio}.
+
+@var properEnv: A copy of L{os.environ} which has L{bytes} keys/values on POSIX
+    platforms and native L{str} keys/values on Windows.
 """
 
 from __future__ import absolute_import, division