Re: Question regarding custom contextFactory for twisted.web.client.Agent
Jean-Paul Calderone <[email protected]> Tue, 4 Jul 2017 08:30:44 -0400
| Newsgroups | gmane.comp.python.twisted.web |
|---|---|
| Message-ID | <CAEeXt4Nvx+7x3EBfGUagaXLNhgy+eZQKJ0n=uAHjE0Y5frDKiA@mail.gmail.com> |
--===============6285752423474909417== Content-Type: multipart/alternative; boundary="f4030435b7fc77427905537d0de4" --f4030435b7fc77427905537d0de4 Content-Type: text/plain; charset="UTF-8" On Mon, Jul 3, 2017 at 11:54 PM, Jason Litzinger <[email protected]> wrote: > > Thanks for pointing this out. Yes, it's a bug. Also, it turns out > > re-using serial numbers is a bad idea too. I don't think their mistake > > *currently* hurts the tests but it would be great to get them both fixed. > > So a PR would be quite welcome. > No problem. I noticed most of the branches merged into txkube > correspond to issues, do you want an issue first? Also, is the branch > naming convention <issue>.<branch-name>? > Yes and yes. Thanks! > > -Jason > > _______________________________________________ > Twisted-web mailing list > [email protected] > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web > --f4030435b7fc77427905537d0de4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote">On M= on, Jul 3, 2017 at 11:54 PM, Jason Litzinger <span dir=3D"ltr"><<a href= =3D"mailto:[email protected]" target=3D"_blank">[email protected]= om</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"marg= in:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D""= >> Thanks for pointing this out.=C2=A0 Yes, it's a bug.=C2=A0 Also, = it turns out<br> > re-using serial numbers is a bad idea too.=C2=A0 I don't think the= ir mistake<br> </span>> *currently* hurts the tests but it would be great to get them b= oth fixed.<br> <span class=3D"">> So a PR would be quite welcome.<br> </span>No problem.=C2=A0 I noticed most of the branches merged into txkube<= br> correspond to issues, do you want an issue first?=C2=A0 Also, is the branch= <br> naming convention <issue>.<branch-name>?<br></blockquote><div><= br></div><div>Yes and yes.=C2=A0 Thanks!</div><div>=C2=A0</div><blockquote = class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid= ;padding-left:1ex"> <div class=3D"HOEnZb"><div class=3D"h5"><br> -Jason<br> <br> ______________________________<wbr>_________________<br> Twisted-web mailing list<br> <a href=3D"mailto:[email protected]">Twisted-web@twistedmatrix.= com</a><br> <a href=3D"https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web" = rel=3D"noreferrer" target=3D"_blank">https://twistedmatrix.com/cgi-<wbr>bin= /mailman/listinfo/twisted-<wbr>web</a><br> </div></div></blockquote></div><br></div></div> --f4030435b7fc77427905537d0de4-- --===============6285752423474909417== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVHdpc3RlZC13 ZWIgbWFpbGluZyBsaXN0ClR3aXN0ZWQtd2ViQHR3aXN0ZWRtYXRyaXguY29tCmh0dHBzOi8vdHdp c3RlZG1hdHJpeC5jb20vY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL3R3aXN0ZWQtd2ViCg== --===============6285752423474909417==--