Re: Twisted 18.7.0rc1 Release Candidate Announcement

Am 04.07.2018 um 12:44 schrieb Amber Brown:
> You can read the full changelog here:
> 
> https://github.com/twisted/twisted/blob/release-18.7.0-9475/NEWS.rst
> 
> Please do some testing, and if all goes well, 18.7 will release proper
> in a week.


Noticed a documentation issue with #9387 (see #9479) and as I was
preparing a patch for it, I noticed that it implemented `samesite` as an
argument which AFAIU is in violation of Twisted coding style.

Just to illustrate: the same method has another parameter called
`httpOnly` and one called `max_age`. Having `samesite` adds yet a third
style to the same method.
AFAIU, the Naming Convention suggests it should be `sameSite` instead.

Opened another ticket for that (#9480). Since once this is released,
it's pretty much un-changable, I would think it's release critical;
"Release blocker: Regression" sounded like the most suitable tag.

See Pull Request: https://github.com/twisted/twisted/pull/1036


#9479: https://twistedmatrix.com/trac/ticket/9387

https://github.com/twisted/twisted/commit/1504c345c2b3ce73b63cf8d27f353c5e9be70f4f#diff-a31693cfdecc4bc57f3dd9ce31445237R1154
#9479: https://twistedmatrix.com/trac/ticket/9479
#9480: https://twistedmatrix.com/trac/ticket/9480
-- 
Evilham

_______________________________________________
Twisted-Python mailing list
[email protected]
https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python