Re: Status of: "console support for stdio in Windows"
Glyph <[email protected]> Mon, 9 Dec 2019 23:18:22 -0800
| Newsgroups | gmane.comp.python.twisted |
|---|---|
| Message-ID | <[email protected]> |
--===============5537709772574344454== Content-Type: multipart/alternative; boundary="Apple-Mail=_F7E7FC69-1B96-4444-AEF5-73DF1BA43E7B" --Apple-Mail=_F7E7FC69-1B96-4444-AEF5-73DF1BA43E7B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Dec 8, 2019, at 8:37 AM, notafile <[email protected]> wrote: >=20 > Hi, >=20 > I just came across the following patches from 13 years ago that fix = StandardIO handling for windows. >=20 > https://twistedmatrix.com/trac/ticket/2157 >=20 > This still appears to be broken, so it seems these patches just got = overlooked and forgotten? To get fixed, a Twisted ticket needs an active champion who is = responding to reviews, fixing CI issues, and generally shepherding the = ticket to completion. Stalled tickets like this are sadly not uncommon. If this issue affects you and you're interested in getting it fixed, it = would be wonderful if you'd pick up the code as it's documented on that = ticket, put it into a new github fork, make a pull request and put it = into review (i.e.: paste a link to the PR on the Trac ticket and add the = 'review' keyword to it). The review queue over on https://twisted.reviews/ = <https://twisted.reviews/> isn't too deep right now so you would have a = good chance of getting a review and getting it integrated assuming it's = got test coverage and everything. Thanks for highlighting this issue! -g --Apple-Mail=_F7E7FC69-1B96-4444-AEF5-73DF1BA43E7B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Dec 8, 2019, at 8:37 AM, notafile <<a = href=3D"mailto:[email protected]" = class=3D"">[email protected]</a>> wrote:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><div class=3D"">Hi,<br= class=3D""><br class=3D"">I just came across the following patches from = 13 years ago that fix StandardIO handling for windows.<br class=3D""><br = class=3D""><a href=3D"https://twistedmatrix.com/trac/ticket/2157" = class=3D"">https://twistedmatrix.com/trac/ticket/2157</a><br = class=3D""><br class=3D"">This still appears to be broken, so it seems = these patches just got overlooked and = forgotten?</div></div></blockquote><br class=3D""></div><div>To get = fixed, a Twisted ticket needs an active champion who is responding to = reviews, fixing CI issues, and generally shepherding the ticket to = completion. Stalled tickets like this are sadly not = uncommon.</div><div><br class=3D""></div><div>If this issue affects you = and you're interested in getting it fixed, it would be <i = class=3D"">wonderful</i><span style=3D"font-style: normal;" = class=3D""> if you'd pick up the code as it's documented on that = ticket, put it into a new github fork, make a pull request and put it = into review (i.e.: paste a link to the PR on the Trac ticket and add the = 'review' keyword to it).</span></div><div><span style=3D"font-style: = normal;" class=3D""><br class=3D""></span></div><div>The review queue = over on <a href=3D"https://twisted.reviews/" = class=3D"">https://twisted.reviews/</a> isn't too deep right now so = you would have a good chance of getting a review and getting it = integrated assuming it's got test coverage and everything.</div><div><br = class=3D""></div><div>Thanks for highlighting this issue!</div><div><br = class=3D""></div><div>-g</div><br class=3D""></body></html>= --Apple-Mail=_F7E7FC69-1B96-4444-AEF5-73DF1BA43E7B-- --===============5537709772574344454== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVHdpc3RlZC1Q eXRob24gbWFpbGluZyBsaXN0ClR3aXN0ZWQtUHl0aG9uQHR3aXN0ZWRtYXRyaXguY29tCmh0dHBz Oi8vdHdpc3RlZG1hdHJpeC5jb20vY2dpLWJpbi9tYWlsbWFuL2xpc3RpbmZvL3R3aXN0ZWQtcHl0 aG9uCg== --===============5537709772574344454==--