socket close-on-exec patch needed anymore on ThreadedAppServer?

I'm in the process of upgrading Webware to version 1.0.2 from version 0.8.4
We currently have a patch that we apply to the older version to add in socket close-on-exec within the ThreadedAppServer, like so:

--- Webware.orig/WebKit/ThreadedAppServer.py	Thu Mar 21 11:40:40 2002
+++ Webware/WebKit/ThreadedAppServer.py	Tue Oct  1 14:11:28 2002
@@ -26,6 +26,7 @@
 import select
 import socket
 import threading
+import fcntl
 import time
 import errno
 import traceback
@@ -105,6 +106,7 @@
 
 		# @@ 2001-05-30 ce: another hard coded number:  @@jsl- not everything needs to be configurable....
 		self.mainsocket.listen(1024)
+           fcntl.fcntl(self.mainsocket.fileno(), fcntl.F_SETFD, 1)
 		self.recordPID()
 
 		print "Ready\n"

We are running FreeBSD 6.1

Do we need to reapply this patch to Webware 1.0.2, or was ThreadedAppServer rewritten to avoid this problem?

-Justin Akehurst


Justin Akehurst
Software Design Engineer - UI
Isilon Systems, Inc  www.isilon.com
P +1-206-315-7500   F +1-206-315-7501 
D +1-206-315-7576  
The Proven Leader in Scale-out NAS
Simplicity and Value. Guaranteed 
 


------------------------------------------------------------------------------