Re: Relevance of very outdated `Pythonwin/pywin/idle`
Mark Hammond <[email protected]> Fri, 12 Jan 2024 13:12:40 -0500
| Newsgroups | gmane.comp.python.windows |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============4080107539753808431== Content-Type: multipart/alternative; boundary="------------EHrHSEuWHMrppzPmcm9GYQcU" Content-Language: en-US This is a multi-part message in MIME format. --------------EHrHSEuWHMrppzPmcm9GYQcU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Some of those modules are actually used by pythonwin, particularly by pywin/scintilla - so while I agree the ability to update them is questionable, I don't think just killing the directory makes sense. Did you try to remove it? I'd be surprised if Pythonwin continues to work in that scenario. I also don't see a huge maintenance cost nor must automated tooling churn - I haven't seen much in the way of external PRs touching this, nor have I personally touched these files recently - indeed most of the churn I see if from the *introduction* of such tooling, so one solution to that is probably to not try and introduce new tooling which touches or checks these files. Cheers, Mark On 2024-01-12 12:50 p.m., Samuel Therrien wrote: > Hi! > > I recently had to do a deep dive into > https://github.com/mhammond/pywin32/tree/main/Pythonwin/pywin/idle > <https://github.com/mhammond/pywin32/tree/main/Pythonwin/pywin/idle> as > part of a previous PR. See comment: > https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005 > <https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005> > > Of course it is extremely outdated, but I think the interesting part > is that these IDLE modules are now part of the cpython repo (although > most have been renamed over time), and some modules seem to not even > be used as part of pythonwin. > > I basically expect that none of this works at all today, especially > given the minimum version requirement of Python 3.7-3.8. Is this worth > keeping around at all? > > * > Pythonwin will look for IDLE extensions first in this directory, > then on the global sys.path. Thus, if you have IDLE installed and > run it from the CVS sources, you may remove most of the extensions > from this directory, and the latest CVS version will then be used. > > Could we just delete this entire folder instead, and update > references, reducing further maintenance cost and automated tooling > churn? Anything special I should look for in testing? > <https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005> > > Basic type-checking with mypy and pyright by Avasam · Pull Request > #2102 · mhammond/pywin32 > <https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005> > This is the PR that finally makes basic type-checking validation of > public methods possible, easing the addition of 3.7+ type annotations. > In its current state, a lot of checks are disabled, and so... > github.com > > // > > > _______________________________________________ > python-win32 mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-win32 --------------EHrHSEuWHMrppzPmcm9GYQcU Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <p>Some of those modules are actually used by pythonwin, particularly by pywin/scintilla - so while I agree the ability to update them is questionable, I don't think just killing the directory makes sense. Did you try to remove it? I'd be surprised if Pythonwin continues to work in that scenario.</p> <p><br> </p> <p>I also don't see a huge maintenance cost nor must automated tooling churn - I haven't seen much in the way of external PRs touching this, nor have I personally touched these files recently - indeed most of the churn I see if from the *introduction* of such tooling, so one solution to that is probably to not try and introduce new tooling which touches or checks these files.<br> </p> <p><br> </p> <p>Cheers,</p> <p><br> </p> <p>Mark<br> </p> <p><br> </p> <div class="moz-cite-prefix">On 2024-01-12 12:50 p.m., Samuel Therrien wrote:<br> </div> <blockquote type="cite" cite="mid:DM6PR02MB45716F2D72571747C4C97736E46F2@DM6PR02MB4571.namprd02.prod.outlook.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style> <div class="elementToProof"><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Hi!<br> <br> I recently had to do a deep dive into </span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><a href="https://github.com/mhammond/pywin32/tree/main/Pythonwin/pywin/idle" id="LPlnk471199" class="OWAAutoLink moz-txt-link-freetext" moz-do-not-send="true">https://github.com/mhammond/pywin32/tree/main/Pythonwin/pywin/idle</a></span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> as part of a previous PR. See comment: </span><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><a href="https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005" id="LPlnk" class="OWAAutoLink moz-txt-link-freetext" moz-do-not-send="true">https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005</a><br> <br> Of course it is extremely outdated, but I think the interesting part is that these IDLE modules are now part of the cpython repo (although most have been renamed over time), and some modules seem to not even be used as part of pythonwin.<br> <br> I basically expect that none of this works at all today, especially given the minimum version requirement of Python 3.7-3.8. Is this worth keeping around at all?<br> <br> </span></div> <ul data-editing-info="{"orderedStyleType":1,"unorderedStyleType":4}" style="margin-block: 0px;"> <li style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; list-style-type: "➢ "; color: rgb(0, 0, 0);"> <pre style="margin-top: 0px; margin-bottom: 0px; background-color: rgb(13, 17, 23);"><div style="text-align: left;"><span style="letter-spacing: normal; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace; font-size: 12px; font-weight: 400; color: rgb(230, 237, 243);">Pythonwin will look for IDLE extensions first in this directory, then on the global sys.path. Thus, if you have IDLE installed and run it from the CVS sources, you may remove most of the extensions from this directory, and the latest CVS version will then be used.</span></div></pre> <div><span style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br> </span></div> </li> </ul> <div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Could we just delete this entire folder instead, and update references, reducing further maintenance cost and automated tooling churn? Anything special I should look for in testing?</div> <div class="_Entity _EType_OWALinkPreview _EId_OWALinkPreview_5 _EReadonly_1"> <div id="LPBorder_GTaHR0cHM6Ly9naXRodWIuY29tL21oYW1tb25kL3B5d2luMzIvcHVsbC8yMTAyI2Rpc2N1c3Npb25fcjEzODA0MjIwMDU." class="LPBorder831067" style="width: 100%; margin-top: 16px; margin-bottom: 16px; position: relative; max-width: 800px; min-width: 424px;"> <table id="LPContainer831067" role="presentation" style="padding: 12px 36px 12px 12px; width: 100%; border-width: 1px; border-style: solid; border-color: rgb(200, 200, 200); border-radius: 2px;"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td> <div id="LPImageContainer831067" style="position: relative; margin-right: 12px; height: 120px; overflow: hidden; width: 240px;"> <a target="_blank" id="LPImageAnchor831067" href="https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005" moz-do-not-send="true"><img id="LPThumbnailImageId831067" alt="" height="120" style="display: block;" width="240" src="https://opengraph.githubassets.com/b62496876f356f98f081228d039b0186cbce83377c606fe280d33ceba55766fc/mhammond/pywin32/pull/2102" moz-do-not-send="true"></a></div> </td> <td style="width: 100%;"> <div id="LPTitle831067" style="font-size: 21px; font-weight: 300; margin-right: 8px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px;"> <a target="_blank" id="LPUrlAnchor831067" href="https://github.com/mhammond/pywin32/pull/2102#discussion_r1380422005" style="text-decoration: none;" moz-do-not-send="true">Basic type-checking with mypy and pyright by Avasam · Pull Request #2102 · mhammond/pywin32</a></div> <div id="LPDescription831067" style="font-size: 14px; max-height: 100px; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; margin-bottom: 12px; margin-right: 8px; overflow: hidden; color: rgb(102, 102, 102);"> This is the PR that finally makes basic type-checking validation of public methods possible, easing the addition of 3.7+ type annotations. In its current state, a lot of checks are disabled, and so...</div> <div id="LPMetadata831067" style="font-size: 14px; font-weight: 400; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; color: rgb(166, 166, 166);"> github.com</div> </td> </tr> </tbody> </table> <div id="LPCloseButtonContainer831067" class="uHkAz" tabindex="0" title="Remove link preview" role="button"> <i data-icon-name="Cancel" aria-hidden="true" id="LPCloseButton831067" class="Rm9Q1 root-380"></i></div> </div> </div> <div class="elementToProof" style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <br> <fieldset class="moz-mime-attachment-header"></fieldset> <pre wrap="" class="moz-quote-pre">_______________________________________________ python-win32 mailing list <a class="moz-txt-link-abbreviated" href="mailto:[email protected]">[email protected]</a> <a class="moz-txt-link-freetext" href="https://mail.python.org/mailman/listinfo/python-win32">https://mail.python.org/mailman/listinfo/python-win32</a> </pre> </blockquote> </body> </html> --------------EHrHSEuWHMrppzPmcm9GYQcU-- --===============4080107539753808431== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ python-win32 mailing list [email protected] https://mail.python.org/mailman/listinfo/python-win32 --===============4080107539753808431==--