Re: Re: [Phoenix] FloatCanvas and sized_controls (#78)

Hi Chris,

On 2/12/2015 1:39, Chris Barker wrote:
> Just saw this...
>
> On Wed, Feb 11, 2015 at 5:47 AM, Werner <[email protected] 
> <mailto:[email protected]>> wrote:
>
>
>     The cause is in floatcanvas/FCObjects.py line 49 did:
>     ComputeFontScale()
>
>
> yup -- I suspected that the moment I heard about the issue.
>
>     I move this to the __init__ of floatcanvas, tests work.
>
>     Chris do you think that is fine?
>
>
> yeah, that should be fine -- I probably should have put in there in 
> the first place.
Hhm, I think that was actually me you made that change during the 
refactor related to FCObjects.

BTW, when you have a moment could you review the doc strings, I noticed 
that this is still not documented.

     def SetUpDraw(self, dc, WorldToPixel, ScaleWorldToPixel, HTdc):
         """
         Setup for draw

         :param `dc`: the dc to draw ???
         :param `WorldToPixel`: ???
         :param `ScaleWorldToPixel`: ???
         :param `HTdc`: ???

         """

Could you either update it or give me the text and I do another PR.

Werner

-- 
You received this message because you are subscribed to the Google Groups "wxPython-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.