Re: wxPython pdfViewer demo

typical name <[email protected]> Mon, 8 Oct 2018 15:14:57 -0700 (PDT)
Newsgroups gmane.comp.python.wxpython.devel
Message-ID <[email protected]>
Ok, thanks for the advice. I will fork and issue a pull request, since I 
would call the changes "medium".

I would like to "run the tests." 
But I'm not exactly how to do this. 
I am teaching myself python, and am not an experienced developer.

I assume you mean that I should run the suite of unit tests?
(Phoenix/tree/master/unittests)

I have not ever done that before. 
I would welcome advice as to how to get started doing that so I can be a 
better contributor....

Thanks!

G




On Monday, October 8, 2018 at 4:26:42 PM UTC-4, Hélio Guilherme wrote:
>
> There are advantages of forking the GitHub project, because you may have 
> more changes. corrections or more future Pull Requests. You could (and 
> should) run the tests locally to prove the changes are working and they did 
> not impacted other areas.
>
> If the changes are really small, and you think you will not contribute 
> with other changes or improvements, then you can post the core here.
>
> segunda-feira, 8 de Outubro de 2018 às 16:10:42 UTC+1, typical name 
> escreveu:
>>
>>
>> Hi all,
>>
>> I'm new to cooperative development, so forgive my obvious questions.
>>
>> I have made what I think are useful improvements to the 
>> wx/lib/pdfviewer/viewer.py library.
>>
>> However, I don't know how best to contribute them.
>>
>> Can I email my updated file to someone?
>>
>> Or do I have to clone the github repo and do a pull request?
>>
>> Thanks,
>>
>> G
>>
>

-- 
You received this message because you are subscribed to the Google Groups "wxPython-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.