Re: Class hierarchy for thumbnailctrl

On 9/8/20 10:49 AM, Andrea Gavana wrote:
> Hi,
> 
> On Tue, 8 Sep 2020 at 18.45, Michael Eager <[email protected] 
> <mailto:[email protected]>> wrote:
> 

>     There are some problems with the control.  Setting the Zoom factor
>     doesn't do anything; the _zoomfactor value is never used. Zooming with
>     the + or - key doesn't appear to have any affect.
> 
> It should, or at least it did in wxPython Classic. See the methods 
> ZoomIn and ZoomOut - they don’t rely directly on the _zoomfactor 
> attribute, they rather call GetZoomFactor. Have you tried setting the 
> focus on the ThumbnailCtrl via mouse click and then use the mouse wheel 
> (with the Ctrl Key pressed) using the + or - keys.

Setting focus and using the mouse wheel does work.  Hitting + or - does 
not.  The SetZoomFactor method does not appear to work.

>     I have the impression that thumbnailctrl.py is an app trying to
>     masquerade as a control.  It does more than just display thumbnails
>     in a
>     window:  it reads a directory, sorts the files by name, displays a
>     combobox with the path, deletes files, maybe more.  This makes it much
>     less flexible as a control, for example, if I want to display
>     thumbnails
>     in a different order, or supply images to be displayed, rather a
>     directory.  Some of these features, like displaying a combobox with the
>     path, could easily be done in an app which used a simpler thumbnail
>     display control.
> 
> I’ve already heard this remark/critique about ThumbnailCtrl, and I 
> believe it’s a valid point. That said, I am not that much involved in 
> the development of wxPython anymore, so until someone steps up and 
> modify the control to make it more generic/less app-style I guess it 
> will stay as it is.

I might be interest in trying to do this.  Removing functionality would 
make it no longer backward compatible.  What would be the right way to 
do this?  Create a NewThumbnailCtrl.py with the reduced/simplified 
functionality?

-- 
Michael Eager

-- 
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/wxpython-users/604662f5-ebe2-6e97-97ec-aca5e502313b%40eagercon.com.