Re: Help Regarding, Improve Estimated total number of results
Hemant Kumar Singh <[email protected]> Wed, 10 Apr 2019 11:06:09 +0530
| Newsgroups | gmane.comp.search.xapian.devel |
|---|---|
| Message-ID | <[email protected]> |
--5cad80c9_5fb03ba9_38aa Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Thanks, as per my knowledge, after downloading the source code, and making changes and then making sure it works properly , recompiling it and then patch it and finally submit a pull request. But what all changes should I/can I make? Please provide me some insight into this. Thanks&Regards, Hemant Kumar Singh On Apr 10 2019, at 10:56 am, Gaurav Arora <[email protected]> wrote: > The easiest way to submit a patch is Pull Request on GitHub. > > This (https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project) or https://www.geeksforgeeks.org/making-first-open-source-pull-request/ might give you more details on how to open a pull request. > > > > On Wed, Apr 10, 2019 at 2:13 PM Hemant Kumar Singh <[email protected] (mailto:[email protected])> wrote: > > Okay thanks, how do I make a patch and submit one? Do you have a link for the same? > > > > Thanks&Regards, > > Hemant Kumar Singh > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Apr 10 2019, at 4:13 am, Olly Betts <[email protected] (mailto:[email protected])> wrote: > > > On Tue, Apr 09, 2019 at 04:07:58PM +0530, Hemant Kumar Singh wrote: > > > > The GSoC guide section recommends reading of the hacking. > > > > > > > > > I don't actually see a reference to HACKING on > > > https://trac.xapian.org/wiki/GSoC%20Guide but it does direct you to the > > > developer guide (which is the new home for much of the information that > > > was living in HACKING). > > > > > > > But there > > > > are many files in the resources link given for the project. Should I > > > > start from the matcher files (matcher.cc and matcher.h) or is there > > > > something else I should do? > > > > > > > > > Most of the files in the matcher subdirectory are relevant to this > > > project, but matcher.* is probably a good place to start. > > > > > > Cheers, > > > Olly > > > > > > > > > > -- > Regards, > Gaurav Arora > > > --5cad80c9_5fb03ba9_38aa Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline <div>Thanks, as per my knowledge, after downloading the source code, and = making changes and then making sure it works properly , recompiling it an= d then patch it and finally submit a pull request. </div><br><div>But wha= t all changes should I/can I make=3F Please provide me some insight into = this.</div><br><div>Thanks&Regards,</div><div><signature id=3D=22init= ial=22><div><table cellpadding=3D=220=22 cellspacing=3D=220=22><tbody><tr= ><td colspan=3D=222=22><div style=3D=22padding-bottom:15px=22><div><stron= g>Hemant Kumar Singh</strong></div></div></td></tr><tr><td style=3D=22ver= tical-align:top=22></td><td><div style=3D=22font-size:0.9em;white-space:n= owrap;border-left:2px solid gray;margin-left:20px;padding-left:20px=22><d= iv><div></div><div><a href=3D=22https://www.linkedin.com/in/iamhks=22 tit= le=3D=22LinkedIn=22 style=3D=22margin-right:8px=22><img src=3D=22https://= www.getmailspring.com/signature-assets/linkedin.gif=22 width=3D=2213=22 h= eight=3D=2213=22 alt=3D=22LinkedIn=22></a></div></div></div></td></tr></t= body></table></div></signature></div><div class=3D=22gmail=5Fquote=5Fattr= ibution=22>On Apr 10 2019, at 10:56 am, Gaurav Arora <gauravarora.daii= ct=40gmail.com> wrote:</div><blockquote><div><div><div>The easiest way= to submit a patch is Pull Request on GitHub.</div><div><br></div><div>Th= is (<a href=3D=22https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-= Project=22 title=3D=22https://git-scm.com/book/en/v2/GitHub-Contributing-= to-a-Project=22>https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-P= roject</a>) or <a href=3D=22https://www.geeksforgeeks.org/making-fir= st-open-source-pull-request/=22 title=3D=22https://www.geeksforgeeks.org/= making-first-open-source-pull-request/=22>https://www.geeksforgeeks.org/m= aking-first-open-source-pull-request/</a> might give you more detail= s on how to open a pull request.</div><div><br></div><div><br></div></div= ><br><div class=3D=22gmail=5Fquote=22><div class=3D=22gmail=5Fattr=22><di= v>On Wed, Apr 10, 2019 at 2:13 PM Hemant Kumar Singh <<a href=3D=22mai= lto:hkssheroksher=40gmail.com=22 title=3D=22mailto:hkssheroksher=40gmail.= com=22>hkssheroksher=40gmail.com</a>> wrote:</div></div><blockquote><d= iv>Okay thanks, how do I make a patch and submit one=3F Do you have a lin= k for the same=3F</div><br><div>Thanks&Regards,</div><div><div><div><= div><table cellpadding=3D=220=22 cellspacing=3D=220=22><tbody><tr><td col= span=3D=222=22><div style=3D=22padding-bottom:15px=22><div><strong>Hemant= Kumar Singh</strong></div></div></td></tr><tr><td style=3D=22vertical-al= ign:top=22></td><td><div style=3D=22font-size:0.9em;white-space:nowrap;bo= rder-left:2px solid gray;margin-left:20px;padding-left:20px=22><div><div>= </div><div><a href=3D=22https://www.linkedin.com/in/iamhks=22 title=3D=22= LinkedIn=22 style=3D=22margin-right:8px=22 target=3D=22=5Fblank=22><img s= rc=3D=22https://www.getmailspring.com/signature-assets/linkedin.gif=22 wi= dth=3D=2213=22 height=3D=2213=22 alt=3D=22LinkedIn=22></a></div></div></d= iv></td></tr></tbody></table></div></div></div></div><div class=3D=22gmai= l-m=5F309213991669288251gmail=5Fquote=5Fattribution=22>On Apr 10 2019, at= 4:13 am, Olly Betts <<a href=3D=22mailto:olly=40survex.com=22 title=3D= =22mailto:olly=40survex.com=22>olly=40survex.com</a>> wrote:</div><blo= ckquote><div><div>On Tue, Apr 09, 2019 at 04:07:58PM +0530, Hemant Kumar = Singh wrote:</div><blockquote><div>The GSoC guide section recommends read= ing of the hacking.</div></blockquote><br><div>I don't actually see a ref= erence to HACKING on</div><div><a href=3D=22https://trac.xapian.org/wiki/= GSoC%20Guide=22 title=3D=22https://trac.xapian.org/wiki/GSoC%20Guide=22>h= ttps://trac.xapian.org/wiki/GSoC%20Guide</a> but it does direct you to th= e</div><div>developer guide (which is the new home for much of the inform= ation that</div><div>was living in HACKING).</div><br><blockquote><div>Bu= t there</div><div>are many files in the resources link given for the proj= ect. Should I</div><div>start from the matcher files (matcher.cc and matc= her.h) or is there</div><div>something else I should do=3F</div></blockqu= ote><br><div>Most of the files in the matcher subdirectory are relevant t= o this</div><div>project, but matcher.* is probably a good place to start= .</div><br><div>Cheers,</div><div>Olly</div></div></blockquote></blockquo= te></div><br><div><br></div><div>--</div><div class=3D=22gmail=5Fsignatur= e=22><div><div>Regards,</div><div>Gaurav Arora</div></div></div></div></b= lockquote> --5cad80c9_5fb03ba9_38aa--