Re: mutex_lock function and sasl_set_mutex

It seems to me that that's true. We should have the read/write to m->val within a critical section, otherwise this will be susceptible to race conditions.

________________________________
From: Cyrus-sasl <[email protected]> on behalf of Ted Yu <[email protected]>
Sent: Sunday, April 16, 2017 3:38 AM
To: W. Michael Petullo
Cc: [email protected]
Subject: mutex_lock function and sasl_set_mutex

Hi,
Looking at sasl_set_mutex function shown in cyrus-sasl-2.1.26/utils/testsuite.c :

int my_mutex_lock(my_mutex_t *m)
{
    if (m->val != 0)
    {
      fatal("Trying to lock a mutex already locked [single-threaded app]");
    }

Wouldn't calling pthread_mutex_lock() better handle concurrent invocations of the mutex lock function ?

Thanks