Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash

Greg KH <[email protected]> wrote:
> > I think this function should WARN_ON_ONCE when one tries to reinsert a
> > dead expectation (and return -EINVAL or another appropriate error).
> > 
> > (This is indenpendent of the real fix).
> 
> If you do that, then the machine will reboot, loosing everything.
> Are you sure you want that to happen?

Of course not, i never set panic_on_warn.

> Why not just properly handle the
> issue if it possibly could happen?

This is no different than the WARNs on list corruption or refcount
under/overflows.

Would you propose to remove those?  I hope not, they help catch bugs.