Re: [PATCH nf] netfilter: nf_nat: do not reuse an unexpected expectation on RTCP clash
Florian Westphal <[email protected]>
| Newsgroups | gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <[email protected]> |
Greg KH <[email protected]> wrote: > > This is no different than the WARNs on list corruption or refcount > > under/overflows. > > True, but adding new ones is not a good idea, and removing the existing > ones is a good idea. We're fucked, then. Can we at least use DEBUG_NET_WARN or something like that so at least fizzers can give us hints about bugs?! > > Would you propose to remove those? I hope not, they help catch bugs. > > Bugs that userspace can trigger? If so, then properly catch them by > testing and handling the issue. Aka "Don't write buggy code". Should have thought of that. > If userspace can never trigger it, then > it's not really needed as the code is never going to trigger. It causes memory corruption and evidently triggers. With "silently catch error" and no WARN there will be rare, intermittent connectivity issues. We are NOT in a syscall, there is no process to return a meaningful error code to. With WARN at least there is some chance that someone will report it so underlying root cause gets fixed. EOD from my side, have iot your way, silent ignore it is.