Re: [nft PATCH 6/6] netlink: Call tunnel getters unconditionally

On Wed, Jul 22, 2026 at 06:57:10PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Jul 03, 2026 at 11:55:23AM +0200, Phil Sutter wrote:
> > Hi Pablo,
> > 
> > On Fri, Jun 26, 2026 at 01:53:27PM +0200, Pablo Neira Ayuso wrote:
> > > Series LGTM, only one nitpick, see below.
> > 
> > Thanks for your review!
> > 
> > [...]
> > > >  static struct expr *
> > > > -netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int attr)
> > > > +netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int attr, int alt_attr)
> > > 
> > > Maybe I would suggest:
> > > 
> > > netlink_obj_tunnel_parse_addr(struct nftnl_obj *nlo, int ipv4_attr, int ipv6_attr)
> > > 
> > > for easier reading.
> > 
> > Fine with me! I'll introduce 'int attr' auto-variable then, because the
> > code would otherwise conditionally do 'ipv4_attr = ipv6_attr' which is
> > more confusing than the original version.
> 
> Ok, thanks. Feel free to merge this series once you're done with it.

Fixed, rationale added to commit message and pushed after making sure
'make check' passes.

Thanks, Phil