Re: [PATCH net 09/13] ipvs: fix the checksum validations

Jakub Kicinski <[email protected]> Thu, 23 Jul 2026 07:08:45 -0700
Newsgroups gmane.comp.security.firewalls.netfilter.devel,gmane.linux.network
Message-ID <[email protected]>
On Wed, 22 Jul 2026 23:14:16 +0200 Pablo Neira Ayuso wrote:
> +/**
> + * ip_vs_checksum_common_check - validate checksum for TCP/UDP/ICMP
> + */

this not-really-kdoc comment causes a bunch of new warnings,
and this file was previously warning free. Which in turn
makes our AI reviewer ignore the series. Could you respin?

> +static inline bool ip_vs_checksum_common_check(struct sk_buff *skb,
> +					       int offset, int proto, int af)
> +{
> +	if (!ip_vs_checksum_needed(skb, af))
> +		return true;
> +	return !nf_checksum(skb, NF_INET_LOCAL_IN, offset, proto, af);
> +}